Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parity: 2.4.6 -> 2.4.7, parity-beta: 2.5.1 -> 2.5.2 #63011

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@xrelkd
Copy link
Contributor

commented Jun 12, 2019

Motivation for this change

Update parity and parity-beta to the latest release.
https://github.com/paritytech/parity-ethereum/releases/tag/v2.4.7
https://github.com/paritytech/parity-ethereum/releases/tag/v2.5.2

cc @akru to review. Thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd xrelkd force-pushed the xrelkd:update/parity branch 2 times, most recently from d9a2462 to 1509b22 Jun 12, 2019

@xrelkd xrelkd force-pushed the xrelkd:update/parity branch from 1509b22 to 4f63cc3 Jun 12, 2019

@mmahut

mmahut approved these changes Jun 12, 2019

Copy link
Contributor

left a comment

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.