Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openh264: 1.8.0 -> 2.0.0 #64100

Merged
merged 3 commits into from Dec 14, 2019
Merged

openh264: 1.8.0 -> 2.0.0 #64100

merged 3 commits into from Dec 14, 2019

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jul 2, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openh264/versions.

meta.description for openh264 is: '"A codec library which supports H.264 encoding and decoding"'.

meta.homepage for openh264 is: '"http://www.openh264.org"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

690 total rebuild path(s)

234 package rebuild(s)

234 x86_64-linux rebuild(s)
222 i686-linux rebuild(s)
28 x86_64-darwin rebuild(s)
206 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adapta-gtk-theme
almanah
aravis
arc-theme
areca
astroid
audio-recorder
azureus
balsa
baresip
birdfont
bookworm
brasero
brasero-original
byzanz
chrome-gnome-shell
corebird
cutegram
deja-dup
denemo
dragon
dropbox-cli
eclipses.eclipse-cpp
eclipses.eclipse-java
eclipses.eclipse-modeling
eclipses.eclipse-platform
eclipses.eclipse-scala-sdk
eclipses.eclipse-sdk
ekiga
empathy
enlightenment.rage
eolie
ephemeral
epiphany
evince
evolution-data-server
farstream
feedreader
folks
fractal
gajim
gcompris
gfbgraph
glom
gmrender-resurrect
gnome-builder
gnome-podcasts
gnome-recipes
gnome3.bijiben
gnome3.cheese

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/yvjfcdpab02nvyz5vxx29b1pcfpd0ka9-openh264-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A openh264 https://github.com/r-ryantm/nixpkgs/archive/26dc994033d087960bdba09ea8d0a1539d4787a1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/yvjfcdpab02nvyz5vxx29b1pcfpd0ka9-openh264-2.0.0
ls -la /nix/store/yvjfcdpab02nvyz5vxx29b1pcfpd0ka9-openh264-2.0.0/bin

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/openh264/versions
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Diff looks good to me.

Copy link
Contributor

@c0bw3b c0bw3b left a comment

As of now it breaks two reverse-deps

  • mediastreamer-openh264-0.0pre20160801
[ 25%] Building CXX object src/CMakeFiles/msopenh264.dir/msopenh264enc.cpp.o
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp: In member function 'void MSOpenH264Encoder::initialize()':
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:134:29: error: 'struct SSpatialLayerConfig' has no member named 'sSliceCfg'; did you mean 'sSliceArgument'?
    params.sSpatialLayers[0].sSliceCfg.uiSliceMode = SM_DYN_SLICE;
                             ^~~~~~~~~
                             sSliceArgument
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:134:53: error: 'SM_DYN_SLICE' was not declared in this scope
    params.sSpatialLayers[0].sSliceCfg.uiSliceMode = SM_DYN_SLICE;
                                                     ^~~~~~~~~~~~
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:134:53: note: suggested alternative: 'SM_SINGLE_SLICE'
    params.sSpatialLayers[0].sSliceCfg.uiSliceMode = SM_DYN_SLICE;
                                                     ^~~~~~~~~~~~
                                                     SM_SINGLE_SLICE
/build/msopenh264-4cb4b13/src/msopenh264enc.cpp:135:29: error: 'struct SSpatialLayerConfig' has no member named 'sSliceCfg'; did you mean 'sSliceArgument'?
    params.sSpatialLayers[0].sSliceCfg.sSliceArgument.uiSliceSizeConstraint = ms_factory_get_payload_max_size(mFilter->factory);
                             ^~~~~~~~~
                             sSliceArgument
make[2]: *** [src/CMakeFiles/msopenh264.dir/build.make:89: src/CMakeFiles/msopenh264.dir/msopenh264enc.cpp.o] Error 1
  • gst-plugins-bad-1.16.0
[614/841] Compiling C++ object 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o'.
FAILED: ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o 
/nix/store/5yyx688q9qxhb4ypawq7v80fm3ix27dm-gcc-wrapper-8.3.0/bin/c++ -Iext/openh264/8008d81@@gstopenh264@sha -Iext/openh264 -I../ext/openh264 -I. -I../ -I/nix/store/3g67gjxkziv947prkql5irml1b6g10fl-glib-2.62.0-dev/include -I/nix/store/3g67gjxkziv947prkql5irml1b6g10fl-glib-2.62.0-dev/include/glib-2.0 -I/nix/store/876ljm7j1xnx5npjjvlqkqil84mn4cks-glib-2.62.0/lib/glib-2.0/include -I/nix/store/zwf051wir2gyc3j1w558mbncg7fmc1w1-gst-plugins-base-1.16.0-dev/include/gstreamer-1.0 -I/nix/store/34y4114d5bq8pq5z58lwhs15fn4haz0r-gstreamer-1.16.0-dev/include/gstreamer-1.0 -I/nix/store/wnsnxj0qjcxif12gqf65bysc8afybskl-openh264-2.0.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wno-non-virtual-dtor -fno-strict-aliasing -Wformat-nonliteral -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wvla -Wpointer-arith -fPIC -MD -MQ 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o' -MF 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o.d' -o 'ext/openh264/8008d81@@gstopenh264@sha/gstopenh264enc.cpp.o' -c ../ext/openh264/gstopenh264enc.cpp
../ext/openh264/gstopenh264enc.cpp: In function 'gboolean gst_openh264enc_set_format(GstVideoEncoder*, GstVideoCodecState*)':
../ext/openh264/gstopenh264enc.cpp:745:14: error: 'SEncParamExt' {aka 'struct TagEncParamExt'} has no member named 'bEnableSpsPpsIdAddition'
   enc_params.bEnableSpsPpsIdAddition = 0;
              ^~~~~~~~~~~~~~~~~~~~~~~
@c0bw3b
c0bw3b approved these changes Dec 14, 2019
Copy link
Contributor

@c0bw3b c0bw3b left a comment

mediastreamer-openh264 fixed in #74043

gst_all_1.gst-plugins-bad fixed upstream with release 1.16.1 -> #70690

@c0bw3b c0bw3b merged commit 5aae6ee into NixOS:staging Dec 14, 2019
16 checks passed
16 checks passed
openh264 on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
openh264 on aarch64-linux Success
Details
openh264 on x86_64-linux Success
Details
mgttlinger added a commit to mgttlinger/nixpkgs that referenced this pull request Dec 19, 2019
* openh264: 1.8.0 -> 2.0.0

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/openh264/versions
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/openh264 branch Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.