Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iceshelf: init at unstable-2019-07-03 #64235

Merged
merged 1 commit into from Jul 6, 2019

Conversation

@mmahut
Copy link
Member

commented Jul 3, 2019

Motivation for this change

iceshelf: init at unstable-2019-07-03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut changed the title iceshelf: init at unstable-2019-06-18 iceshelf: init at unstable-2019-07-03 Jul 3, 2019

@mmahut mmahut force-pushed the mmahut:iceshelf branch from e8ed95a to 666d853 Jul 3, 2019

@jonringer
Copy link
Contributor

left a comment

Since python2 is nearing end of life, i would use python3.

pythonPackages is aliased to python27.pkgs

Show resolved Hide resolved pkgs/tools/backup/iceshelf/default.nix Outdated
Show resolved Hide resolved pkgs/tools/backup/iceshelf/default.nix Outdated
Show resolved Hide resolved pkgs/tools/backup/iceshelf/default.nix Outdated
Show resolved Hide resolved pkgs/top-level/all-packages.nix
@mmahut

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

@jonringer good point, however, if the package works fine with python2, I would prefer to leave it up for the distribution to make that decision. Just because the upstream will stop the support doesn't mean all the distributions will, therefore I don't feel comfortable to force this on python3 unless I have to (I tested it on python3 too tho).

@jonringer

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Just mentioned it because https://github.com/mrworf/iceshelf/wiki/Installing-iceshelf doesn't really mention anything about being tied to a particular version, and I'm disillusioned with python2 and it's all it's quarks

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

I think it would be better to just use python3.pkgs in the expression.
I don't think we lose anything by using python3 by default since it's just an application.

Eventually we'll have to switch it over anyway.

@worldofpeace
Copy link
Member

left a comment

Just replace all references of pythonPackages and python with python3 and python3.pkgs

@mmahut mmahut force-pushed the mmahut:iceshelf branch from 666d853 to b7a1daf Jul 6, 2019

@mmahut

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

Thank you, rebased.

@worldofpeace
Copy link
Member

left a comment

Looks good 🎊

@worldofpeace worldofpeace merged commit 7c2ac5b into NixOS:master Jul 6, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
iceshelf on aarch64-linux Success
Details
iceshelf on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.