-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iceshelf: init at unstable-2019-07-03 #64235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since python2 is nearing end of life, i would use python3.
pythonPackages is aliased to python27.pkgs
@jonringer good point, however, if the package works fine with python2, I would prefer to leave it up for the distribution to make that decision. Just because the upstream will stop the support doesn't mean all the distributions will, therefore I don't feel comfortable to force this on python3 unless I have to (I tested it on python3 too tho). |
Just mentioned it because https://github.com/mrworf/iceshelf/wiki/Installing-iceshelf doesn't really mention anything about being tied to a particular version, and I'm disillusioned with python2 and it's all it's quarks |
I think it would be better to just use Eventually we'll have to switch it over anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just replace all references of pythonPackages
and python
with python3
and python3.pkgs
Thank you, rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎊
Motivation for this change
iceshelf: init at unstable-2019-07-03
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)