-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpv: fix drm and vulkan support #64442
Conversation
This comment has been minimized.
This comment has been minimized.
@GrahamcOfBorg build mpv libplacebo |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/24 |
@GrahamcOfBorg build libplacebo |
We're getting
on darwin. vulkan-headers has darwin support But I'm not sure how much work would be required for that to be useful on MacOS. |
Made @tadeokondrak Do you have any instructions on how I can test that this works properly? |
@tadeokondrak I'd also be interested how you've noticed this. Also: According to the changelog the switch to But I would like to merge the addition of Even without this PR Vulkan support seems fine according to the log (I haven't had a closer look though): mpv -v --gpu-api=vulkan "$video" | grep vulkan
[cplayer] Command line options: '-v' '--gpu-api=vulkan' "$video"
[cplayer] List of enabled features: 52 alsa asm atomics caca cplayer cplugins cuda-hwaccel debug-build drm drmprime dvbin dvdnav dvdread dvdread-common egl-helpers egl-x11 fchmod ffmpeg ffnvcodec gbm.h gl gl-wayland gl-x11 glibc-thread-name glob glob-posix gnuc gpl iconv javascript jpeg lcms2 libaf libass libass-osd libav-any libavcodec libavdevice libbluray libdl libm libmpv-shared librt linux-fstatfs lua optimize oss-audio plain-gl posix posix-or-mingw posix-spawn posix-spawn-native pthreads pulse rubberband shaderc shaderc-shared stdatomic uchardet vaapi vaapi-egl vaapi-glx vaapi-wayland vaapi-x-egl vaapi-x11 vdpau vdpau-gl-x11 vt.h vulkan wayland wayland-protocols x11 xv zlib zsh-comp
[vo/gpu/vulkan] Initializing GPU context 'waylandvk'
[vo/gpu/vulkan] Creating instance with extensions:
[vo/gpu/vulkan] VK_KHR_surface
[vo/gpu/vulkan] VK_KHR_wayland_surface
[vo/gpu/vulkan] Initializing GPU context 'x11vk'
[vo/gpu/vulkan] Creating instance with extensions:
[vo/gpu/vulkan] VK_KHR_surface
[vo/gpu/vulkan] VK_KHR_xlib_surface
[vo/gpu/vulkan] Probing for vulkan devices:
[vo/gpu/vulkan] GPU 0: Intel(R) Iris Plus Graphics 640 (Kaby Lake GT3e) (integrated)
[vo/gpu/vulkan] GPU 1: Intel(R) Iris Plus Graphics 640 (Kaby Lake GT3e) (integrated)
[vo/gpu/vulkan] Chose device:
[vo/gpu/vulkan] Device Name: Intel(R) Iris Plus Graphics 640 (Kaby Lake GT3e)
[...]
[vo/gpu/vulkan] Initializing SPIR-V compiler 'shaderc'
[vo/gpu/vulkan] Queue families supported by device:
[vo/gpu/vulkan] QF 0: flags 0x7 num 1
[vo/gpu/vulkan] Using graphics queue (QF 0)
[vo/gpu/vulkan] Creating vulkan device with extensions:
[vo/gpu/vulkan] VK_KHR_swapchain |
FYI: I've just pushed the commit that adds (The rest of this PR has most likely to be delayed until the release of mpv 0.30.0.) |
Motivation for this change
Noticed my Vulkan settings in my mpv config weren't doing anything
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Can someone on Darwin test to see if libplacebo builds on it, and if not, if removing a dependency would fix it (all are optional)?
I was originally going to add libplacebo as only a vulkan dependency (it's required for it), but mpv uses it for more than just vulkan.