Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cordless: init at 2019-06-13 #64609

Closed
wants to merge 1 commit into from
Closed

cordless: init at 2019-06-13 #64609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions pkgs/applications/networking/instant-messengers/cordless/default.nix
View file
Open in desktop
@@ -0,0 +1,30 @@
{ stdenv, buildGoModule, fetchurl }:

buildGoModule rec {
name = "cordless-${version}";
Bios-Marcel marked this conversation as resolved.
Show resolved Hide resolved
version = "2019-06-13";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but may I ask why that's better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchFromGitHub is better to use when you don't rely on a release tarball because nix can do some sort of caching that it can't with fetchurl.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, so it caches parts that are the same instead of the whole tarball, which would be useless.

url = "https://github.com/Bios-Marcel/cordless/archive/${version}.tar.gz";
sha256 = "ef9c4db21b7c75a5263281ed783c905b47e752f8b596575e0a41cd6e7d450566";
};

doCheck = true;

modSha256 = "08a1dg4d7fjdy8w3sbri3ik8k7c1snpa0rzwinal6inzmdyancys";

subPackages = [ "." ];

meta = with stdenv.lib; {
description = "A third party Discord client";
longDescription = ''
Cordless is a third party Discord client that runs on the
commandline and aims to have a low memory footprint and
bandwidth consumption.
'';
homepage = https://www.github.com/Bios-Marcel/cordless;
license = licenses.bsd3;
maintainers = [ "Marcel Schramm <marceloschr@googlemail.com>" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind moving this to maintainers/maintainer-list.nix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do

platforms = platforms.linux;
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Expand Up @@ -740,6 +740,8 @@ in

cozy = callPackage ../applications/audio/cozy-audiobooks { };

cordless = callPackage ../applications/networking/instant-messengers/cordless { };

ctrtool = callPackage ../tools/archivers/ctrtool { };

crumbs = callPackage ../applications/misc/crumbs { };
Expand Down