-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan9port: use C compiler from Nix #66404
plan9port: use C compiler from Nix #66404
Conversation
The install script was escaping the Nix environment on Mac OS by using `xcrun -sdk macos clang` as its C compiler. Using the Nix compiler required declaring the necessary frameworks as inputs and patching build scripts to assume MacOS 10.12 (and not try to detect). So cached derivations prior to this would probably not work on all intended target machines. This *might* also fix installCheck on Darwin on Hydra. Other minor fixes: * Disable parallel building due to a race with a missing y.tab.h * Use NIX_CFLAGS_COMPILE/NIX_LDFLAGS instead of trying to synthesize something like them. * X11 dependencies aren't used on Darwin when the windowing system is correctly detected
Have you sent the CoreFoundation and TMPDIR patches upstream?
|
@alyssais yes, but no response ( 9fans/plan9port#272 and 9fans/plan9port#273 ) |
Another week, still no response from upstream. Any way to get this merged? |
Particularly I don't think we need to wait upstream to incorporate our patches. We can maintain them here and now. If the upstream accepts them, better! Edit: If in seven days no one objects, I will merge it. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
@AndersonTorres it's been 15 days now, but also I just added a small adjustment so that packages that use 9l/9c don't need to have |
@eraserhd thanks! I will update it now! |
The install script was escaping the Nix environment on Mac OS by using
xcrun -sdk macos clang
as its C compiler. Using the Nix compiler required declaring the necessary frameworks as inputs and patching build scripts to assume MacOS 10.12 (and not try to detect).So cached derivations prior to this would probably not work on all intended target machines.
This should also fix installCheck on Darwin on Hydra.
Other minor fixes:
Motivation for this change
Making the Mac plan9port pure. On Darwin, the package now builds with correct clang 7
instead of Apple's clang 10.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @AndersonTorres @bbarker @ftrvxmtrx @KoviRobi (and @alyssais)