Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-make: 0.22.0 -> 0.22.1 #67151

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@xrelkd
Copy link
Contributor

commented Aug 21, 2019

Motivation for this change

Update cargo-make to the latest release.

Note: doCheck is set as false.
Some tests fail because they need network access. However, Travis-CI ensures a proper build.

cargo-make is a subcommand for cargo. You need to invoke cargo-make via cargo command.
To test the binary files in ./result/bin, consider the following commands:

[john@nixos:~/result/bin] PATH=.:$PATH cargo make --version
cargo-make 0.22.1
[john@nixos:~/result/bin] PATH=.:$PATH ./makers --version
makers 0.22.1
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 938a7e5 into NixOS:master Aug 22, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cargo-make on aarch64-linux Success
Details
cargo-make on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ma27

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@xrelkd thanks!

@xrelkd

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@Ma27 You're welcome!

@xrelkd xrelkd deleted the xrelkd:update/cargo-make branch Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.