Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5{9,11}.qtscript: fix errors due to gcc8.3 upgrade #68495

Merged
merged 2 commits into from
Sep 11, 2019
Merged

qt5{9,11}.qtscript: fix errors due to gcc8.3 upgrade #68495

merged 2 commits into from
Sep 11, 2019

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Sep 11, 2019 •
edited
Loading

Motivation for this change

These were broken by the gcc8.3 upgrade, and the fix is relatively simple (they've been fixed upstream so I pull the patch)
This is wanted for #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @qknight @ttuegel @periklis @bkchr @NixOS/backports

@Taneb Taneb requested a review from ttuegel as a code owner September 11, 2019 12:16
@worldofpeace
Copy link
Contributor

If we add comments with why need the patches (when the could be dropped too) this should be good 👍

@lheckemann lheckemann added this to the 19.09 milestone Sep 11, 2019
@Taneb
Copy link
Contributor Author

Taneb commented Sep 11, 2019

@worldofpeace I've added those comments

worldofpeace
worldofpeace approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built qt511.qtscript and qt59.qtscript with success ❇️

@worldofpeace worldofpeace merged commit 0fda5ef into NixOS:master Sep 11, 2019
@Taneb Taneb deleted the fix-qtscript branch September 11, 2019 12:44
@worldofpeace
Copy link
Contributor

backported in 9b0a4af b4a66c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @worldofpeace @lheckemann