-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peepdf: init at 0.4.2 #69324
peepdf: init at 0.4.2 #69324
Conversation
with python3Packages; [ jsbeautifier colorama future pillow pythonaes ]; | ||
|
||
meta = { | ||
description = "Powerful Python tool to analyze PDF documents "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "Powerful Python tool to analyze PDF documents "; | |
description = "Powerful Python tool to analyze PDF documents"; |
An odd space.
@GrahamcOfBorg build peepdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@offlinehacker Do you still care about this?
sha256 = "1sblv9dsfvh773qmjpxpzlcxibms6kq2x0rkyh55q8njxh16v1kx"; | ||
}; | ||
|
||
postPatch = "sed -i 's/==/>=/' setup.py"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment about what this is for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ekleog it's to relax the version requirements. In nixpkgs we don't have the exact version of the dependencies.
@offlinehacker please rebase on top of master. |
@offlinehacker any chance for a rebase? I can also take this package over if you want. |
I rebased it, still builds and seems to work fine.
So it would be nice if we added those dependencies to enable full functionality. @offlinehacker do you want to continue to be listed as maintainer or do you want to step in @snicket2100? I can't push to your branch @offlinehacker. |
let me try it, but |
Hm, well the |
I used it for solving CTF challenge once, but I think there are other better tools for this. I can close this pull request and if someone needs it, can create separate pull request or put it in overlay. @snicket2100 you have a use for this package? |
yeah let's close it then @offlinehacker |
None I remember right now |
Motivation for this change
Packaged peepdf for pdf forensics
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @