Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peepdf: init at 0.4.2 #69324

Closed
wants to merge 1 commit into from
Closed

Conversation

@offlinehacker
Copy link
Contributor

offlinehacker commented Sep 23, 2019

Motivation for this change

Packaged peepdf for pdf forensics

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

with python3Packages; [ jsbeautifier colorama future pillow pythonaes ];

meta = {
description = "Powerful Python tool to analyze PDF documents ";

This comment has been minimized.

Copy link
@mmahut

mmahut Sep 27, 2019

Member
Suggested change
description = "Powerful Python tool to analyze PDF documents ";
description = "Powerful Python tool to analyze PDF documents";

An odd space.

@mmahut
Copy link
Member

mmahut commented Sep 27, 2019

@GrahamcOfBorg build peepdf

@Ekleog
Ekleog approved these changes Dec 4, 2019
Copy link
Member

Ekleog left a comment

@offlinehacker Do you still care about this?

sha256 = "1sblv9dsfvh773qmjpxpzlcxibms6kq2x0rkyh55q8njxh16v1kx";
};

postPatch = "sed -i 's/==/>=/' setup.py";

This comment has been minimized.

Copy link
@Ekleog

Ekleog Dec 4, 2019

Member

Can you add a comment about what this is for?

This comment has been minimized.

Copy link
@JohnAZoidberg

JohnAZoidberg Jan 6, 2020

Member

@Ekleog it's to relax the version requirements. In nixpkgs we don't have the exact version of the dependencies.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Jan 6, 2020

@offlinehacker please rebase on top of master.

@snicket2100
Copy link
Contributor

snicket2100 commented May 3, 2020

@offlinehacker any chance for a rebase? I can also take this package over if you want.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented May 3, 2020

I rebased it, still builds and seems to work fine.
However, the program mentions at runtime that:

Warning: PyV8 is not installed!!
Warning: pylibemu is not installed!!

So it would be nice if we added those dependencies to enable full functionality.

@offlinehacker do you want to continue to be listed as maintainer or do you want to step in @snicket2100?

I can't push to your branch @offlinehacker.

@snicket2100
Copy link
Contributor

snicket2100 commented May 4, 2020

let me try it, but PyV8 will likely require some hacking to get it working on python3 as it's old and not maintained anymore :/ but let me try first.

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented May 7, 2020

Hm, well the peepdf package itself is quite old and hasn't seen new commits for a few years.
Do we even want it?

@offlinehacker
Copy link
Contributor Author

offlinehacker commented May 7, 2020

I used it for solving CTF challenge once, but I think there are other better tools for this. I can close this pull request and if someone needs it, can create separate pull request or put it in overlay.

@snicket2100 you have a use for this package?

@snicket2100
Copy link
Contributor

snicket2100 commented May 7, 2020

yeah let's close it then @offlinehacker
btw do you know any similar/better tool?

@offlinehacker
Copy link
Contributor Author

offlinehacker commented May 8, 2020

None I remember right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.