-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/zfs: ZED config module #72734
nixos/zfs: ZED config module #72734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looking pretty good!
@infinisil Is it good ? I can squash the commits if it's ready to be merged |
2cb481c
to
3737757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! After your squash I'll merge
Co-authored-by: sjau <github.com@sjau.ch>
3737757
to
c082e13
Compare
@infinisil I squashed all into one commit |
Motivation for this change
Continue work from #64306
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @