Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/zfs: ZED config module #72734

Merged
merged 1 commit into from Dec 5, 2019
Merged

Conversation

@nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 3, 2019

Motivation for this change

Continue work from #64306

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre nyanloutre changed the title Zfs zed config module nixos/zfs: ZED config module Nov 3, 2019
Copy link
Member

@Infinisil Infinisil left a comment

Nice, looking pretty good!

nixos/modules/tasks/filesystems/zfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Outdated Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Show resolved Hide resolved
nixos/modules/tasks/filesystems/zfs.nix Show resolved Hide resolved
@nyanloutre
Copy link
Member Author

@nyanloutre nyanloutre commented Dec 3, 2019

@Infinisil Is it good ? I can squash the commits if it's ready to be merged

@nyanloutre nyanloutre force-pushed the nyanloutre:zfs_zed_config_module branch from 2cb481c to 3737757 Dec 4, 2019
Copy link
Member

@Infinisil Infinisil left a comment

Looking good! After your squash I'll merge

Co-authored-by: sjau <github.com@sjau.ch>
@nyanloutre nyanloutre force-pushed the nyanloutre:zfs_zed_config_module branch from 3737757 to c082e13 Dec 4, 2019
@nyanloutre
Copy link
Member Author

@nyanloutre nyanloutre commented Dec 4, 2019

@Infinisil I squashed all into one commit

@Infinisil Infinisil merged commit 89b1bd1 into NixOS:master Dec 5, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nyanloutre nyanloutre deleted the nyanloutre:zfs_zed_config_module branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.