Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome2.gnome_vfs: openssl-1.1 patch #72986

Merged
merged 1 commit into from Nov 12, 2019
Merged

Conversation

@juaningan
Copy link
Contributor

juaningan commented Nov 7, 2019

Motivation for this change

Get rid of openssl-1.0 for java projects, I'm struggling to package java apps where openssl-1.1 is mandatory. I have override it successfully and think is interesting commit upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @jtojnar

@juaningan

This comment has been minimized.

Copy link
Contributor Author

juaningan commented Nov 7, 2019

Sorry about not nix-review. The list of deps is too big for my laptop. Tested openjdk11 and working well.

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Nov 7, 2019

Does Java even still need those GNOME 2 dependencies? They have been deprecated for like ten years now.

@juaningan

This comment has been minimized.

Copy link
Contributor Author

juaningan commented Nov 7, 2019

I guess not, but them are called by openjdk packages when enableGnome2 is true (default).

ping: @edwtjo

@juaningan

This comment has been minimized.

Copy link
Contributor Author

juaningan commented Nov 11, 2019

Related: #73246

@juaningan juaningan force-pushed the juaningan:gnome_vfs_openssl11 branch from 0b9eb55 to ff84bc9 Nov 11, 2019
@juaningan juaningan force-pushed the juaningan:gnome_vfs_openssl11 branch 2 times, most recently from 0743ac1 to ce3493c Nov 11, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Nov 11, 2019

Could you squash the commits too?

Use fetchpatch and explain the issue
@globin globin merged commit bfe6cb0 into NixOS:staging Nov 12, 2019
15 checks passed
15 checks passed
gnome2.gnome_vfs on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
gnome2.gnome_vfs on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Needs review to Done Nov 12, 2019
@juaningan juaningan deleted the juaningan:gnome_vfs_openssl11 branch Nov 12, 2019
@juaningan juaningan mentioned this pull request Nov 14, 2019
6 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.