Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebayes: 2017-08-23 -> 1.3.1 (2019-06-03) #73340

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

@kwohlfahrt
Copy link
Contributor

kwohlfahrt commented Nov 13, 2019

Motivation for this change

Version bump.

A lot of the python scripts in result/bin can't be executed (before and after this change) because they don't find the interpreter. Should they be removed or left in place?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jdagilliland

@kwohlfahrt

This comment has been minimized.

Copy link
Contributor Author

kwohlfahrt commented Nov 18, 2019

Suggestion committed, should be good to go now.

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 18, 2019

do you mind squishing the change into the last commit?

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
git push <fork> <branch> --force
@jonringer

This comment has been minimized.

@kwohlfahrt kwohlfahrt force-pushed the kwohlfahrt:freebayes branch from d4b4958 to 3fc4c6e Nov 20, 2019
@kwohlfahrt

This comment has been minimized.

Copy link
Contributor Author

kwohlfahrt commented Nov 20, 2019

Done.

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
commits LGTM
executables still seem to work

[2 built, 2 copied (0.2 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73340
1 package were built:
freebayes
@jonringer jonringer merged commit 6b2504f into NixOS:master Nov 20, 2019
15 checks passed
15 checks passed
freebayes on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
freebayes on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@kwohlfahrt kwohlfahrt deleted the kwohlfahrt:freebayes branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.