New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/matomo: backport module fix (19.09) #73692
Conversation
cherry-pick: removed matomo-beta test because there's no beta package
Fixes the phpfpm deprecation warnings about listen and extraConfig by using fpm.socket and settings. Removes phpfpmProcessManagerConfig.
Thank you. That's one less thing I have to do this week that I was planning (OK, hoping) to get done. I'm conflicted about dropping the beta. To be clear, not having the beta build is fine with me, it's the lack of 3.12 that I don't like. If we can backport 3.12 (which should be ready soon) to 19.09 I'd be happy; it did fix at least one rather annoying bug. (Personally, it doesn't affect me, as I run nixos-unstable, but most people will have a broken version) |
As I understand it; @florianjacob and the Matomo people figured out the change that broke it and it will be fixed upstream going forward. It's not in a release yet; but we know what to patch. We're planning on making time to work on that and the systemd changes in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Yes, we should have a 3.12-stable PR soon which will be backported to nixos-19.09 due to (minor) security issues, so matomo-beta is not needed on nixos-19.09. In case 3.13 is not security critical, it might make sense to backport the multi-version infrastructure and offer nixos-19.09 user the manual upgrade to 3.13, but we'll see how that will play out.
Quick glance over code looks fine. I haven't tested or reviewed in detail, but merging based on approval of @florianjacob so we can quickly fix issue in stable release. Thanks to all for work on this! |
@GrahamcOfBorg test matomo |
This is a backport of #69342.
Motivation for this change
The matomo module is broken in NixOS 19.09 as evidenced by the attached test:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @Kiwi @florianjacob @aanderse