Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin.apple_sdk: 10.12 -> 10.13 update #73744

Open
wants to merge 1 commit into
base: master
from

Conversation

@dredozubov
Copy link
Contributor

dredozubov commented Nov 19, 2019

Motivation for this change

Apple DevSDK for OS X Sierra(10.12) became unavailable recently, so trying to build apple_sdk leads to this:

% nix build nixpkgs.darwin.apple_sdk
builder for '/nix/store/k08c0q6vmv8swrkibqap961bkysfg7g8-DevSDK_OSX1012.pkg.drv' failed with exit code 1; last 7 log lines:

  trying http://swcdn.apple.com/content/downloads/28/09/091-29862/pafhn2u002b9slnrxzy9p86rpedycnjhb5/DevSDK_OSX1012.pkg
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download DevSDK_OSX1012.pkg from any mirror
cannot build derivation '/nix/store/s0advspxkj2nmpw9valj66vxx1cfjh1p-MacOS_SDK-10.12.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/s0advspxkj2nmpw9valj66vxx1cfjh1p-MacOS_SDK-10.12.drv' failed
Things done

Updated to use newer DevSDK for OS X 10.13:

nix build nixpkgs.darwin.apple_sdk -I nixpkgs=. and nix build nixpkgs.darwin.apple_sdk.frameworks.CoreServices -I nixpkgs=. finish successfully again.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @copumpkin @LnL7


This change is Reviewable

@copumpkin

This comment has been minimized.

Copy link
Member

copumpkin commented Nov 21, 2019

I've been swamped recently and am not able to look at this until probably mid next month, sorry. @NixOS/darwin-maintainers, can anyone else look and/or test?

@dredozubov

This comment has been minimized.

Copy link
Contributor Author

dredozubov commented Nov 22, 2019

I'm getting some failures in building some of darwin.apple_sdk.frameworks down the road, it would be helpful to get some feedback from people know this ecosystem well. Nevertheless, I don't see a different way of proceeding for darwin users.

@LnL7

This comment has been minimized.

Copy link
Member

LnL7 commented Nov 22, 2019

Yeah, upgrading the SDK version is usually a lot of work.

However luckily some digging, as described by the comments above, points me to the following url which still has the current version. Seems like something on Apple's side changed the location.

$ curl https://swscan.apple.com/content/catalogs/others/index-10.12-1.sucatalog | grep DevSDK
                        <string>https://swdist.apple.com/content/downloads/33/36/041-90419-A_7JJ4H9ZHO2/xs88ob5wjz6riz7g6764twblnvksusg4ps/DevSDK_OSX1012.pkm</string>
                        <string>http://swcdn.apple.com/content/downloads/33/36/041-90419-A_7JJ4H9ZHO2/xs88ob5wjz6riz7g6764twblnvksusg4ps/DevSDK_OSX1012.pkg</string>
$ nix-build '<nix/fetchurl.nix>' --argstr url "http://swcdn.apple.com/content/downloads/33/36/041-90419-A_7JJ4H9ZHO2/xs88ob5wjz6riz7g6764twblnvksusg4ps/DevSDK_OSX1012.pkg" --argstr sha256 1sggc70rypqwcjwr7ciavw8sczwll16cwqxdxrbw7r2qvy3b0nhx --check
checking outputs of '/nix/store/lfm874mgb4pcl8zl6vfml128sa6nf0bw-DevSDK_OSX1012.pkg.drv'...
warning: rewriting hashes in '/nix/store/10336122d689dkkbs2qax503zf0s7jfq-DevSDK_OSX1012.pkg'; cross fingers
/nix/store/10336122d689dkkbs2qax503zf0s7jfq-DevSDK_OSX1012.pkg
@dredozubov dredozubov mentioned this pull request Nov 23, 2019
3 of 10 tasks complete
@dredozubov

This comment has been minimized.

Copy link
Contributor Author

dredozubov commented Nov 23, 2019

@LnL7 Great catch! I've missed this link somehow. Do you have a good idea regarding the apple deprecation process? It's interesting to learn when we'll be forced to update it for sure. I've spent some time figuring out arising issues, but I'm afraid I'm not incentivized enough to do all this work right now if there's an easy fix available.

I've created a separate PR to fix the 10.12 broken link: #73984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.