-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Minimal: 3.7.4 -> 3.7.5 #73824
Conversation
@adisbladis @flokli given you've added it, maybe you should add yourselves as maintainer. |
Base it on python37 so we ensure the package remains up to date.
9422910
to
1bfd011
Compare
Urgh - this was not
|
That's why there is a |
I still end up with the non-minimal python in the runtime closure:
|
fixed with 1939a97 |
Thanks a lot ❤️ |
@@ -46,7 +46,7 @@ with pkgs; | |||
inherit hasDistutilsCxxPatch pythonForBuild; | |||
}; | |||
|
|||
in { | |||
in rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this rec
added? It doesn't seem to be necessary and breaks overriding/adding packages in the Python package set in an overlay using packageOverrides
. The overrides do not end up applied to python3Packages.python.pkgs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @FRidh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed rec in 92d2153. If overriding is broken, show it with an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that fixes it.
Base it on python37 so we ensure the package remains up to date.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @