-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.papermill: init at 1.2.1 #74208
Conversation
Result of 9 package were built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ansiwrap and textwrap both haven't seen an update since January :(, not sure how i feel about them.
@jonringer while it is true that both have not been updated since January they both have their test suites fully enabled and have no external dependencies (ansiwrap depends on textwrap3, textwrap3 has no dependencies). I think these packages should be easy to maintain for this reason. |
That's fair. They do look like they had some release polish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
commits LGTM
https://github.com/NixOS/nixpkgs/pull/74208
9 package were built:
python27Packages.ansiwrap python27Packages.papermill python27Packages.textwrap3 python37Packages.ansiwrap python37Packages.papermill python37Packages.textwrap3 python38Packages.ansiwrap python38Packages.papermill python38Packages.textwrap3
@GrahamcOfBorg build python27Packages.ansiwrap python27Packages.papermill python27Packages.textwrap3 python37Packages.ansiwrap python37Packages.papermill python37Packages.textwrap3 python38Packages.ansiwrap python38Packages.papermill python38Packages.textwrap3 |
darwin failure related to sqlalchemy |
Motivation for this change
@anirrudh wanted this package :) Would be nice to have more jupyterlab python packages.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @