Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.papermill: init at 1.2.1 #74208

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@costrouc
Copy link
Contributor

costrouc commented Nov 25, 2019

Motivation for this change

@anirrudh wanted this package :) Would be nice to have more jupyterlab python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

costrouc added 3 commits Nov 25, 2019
@costrouc costrouc requested review from FRidh and jonringer as code owners Nov 25, 2019
@costrouc
Copy link
Contributor Author

costrouc commented Nov 25, 2019

Result of nix-review pr 74208 1

9 package were built:
  • python27Packages.ansiwrap
  • python27Packages.papermill
  • python27Packages.textwrap3
  • python37Packages.ansiwrap
  • python37Packages.papermill
  • python37Packages.textwrap3
  • python38Packages.ansiwrap
  • python38Packages.papermill
  • python38Packages.textwrap3
Copy link
Contributor

jonringer left a comment

ansiwrap and textwrap both haven't seen an update since January :(, not sure how i feel about them.

@costrouc
Copy link
Contributor Author

costrouc commented Nov 26, 2019

@jonringer while it is true that both have not been updated since January they both have their test suites fully enabled and have no external dependencies (ansiwrap depends on textwrap3, textwrap3 has no dependencies). I think these packages should be easy to maintain for this reason.

@jonringer
Copy link
Contributor

jonringer commented Nov 26, 2019

That's fair. They do look like they had some release polish

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/74208
9 package were built:
python27Packages.ansiwrap python27Packages.papermill python27Packages.textwrap3 python37Packages.ansiwrap python37Packages.papermill python37Packages.textwrap3 python38Packages.ansiwrap python38Packages.papermill python38Packages.textwrap3
@jonringer
Copy link
Contributor

jonringer commented Nov 26, 2019

@GrahamcOfBorg build python27Packages.ansiwrap python27Packages.papermill python27Packages.textwrap3 python37Packages.ansiwrap python37Packages.papermill python37Packages.textwrap3 python38Packages.ansiwrap python38Packages.papermill python38Packages.textwrap3

@jonringer
Copy link
Contributor

jonringer commented Nov 26, 2019

darwin failure related to sqlalchemy

@jonringer jonringer merged commit 2f288db into NixOS:master Nov 26, 2019
16 checks passed
16 checks passed
python27Packages.ansiwrap, python27Packages.papermill, python27Packages.textwrap3, python37Packages.ansiwrap, python37Packages.papermill, python37Packages.textwrap3, python38Packages.ansiwrap, python38Packages.papermill, python38Packages.textwrap3 on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.ansiwrap, python27Packages.papermill, python27Packages.textwrap3, python37Packages.ansiwrap, python37Packages.papermill, python37Packages.textwrap3, python38Packages.ansiwrap, python38Packages.papermill, python38Packages.textwrap3 on aarch64-linux Success
Details
python27Packages.ansiwrap, python27Packages.papermill, python27Packages.textwrap3, python37Packages.ansiwrap, python37Packages.papermill, python37Packages.textwrap3, python38Packages.ansiwrap, python38Packages.papermill, python38Packages.textwrap3 on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.