-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.tesserocr: init at 2.5.0 #74389
Conversation
3db10d6
to
4dc3418
Compare
4dc3418
to
2fb655d
Compare
52dd0f4
to
9d32e57
Compare
the commit message should reflect the install path (what you put into nix-build), so your commit should be "{package path}: {message}": in your case:
|
9d32e57
to
b4b5934
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
https://github.com/NixOS/nixpkgs/pull/74389
3 package were built:
python27Packages.tesserocr python37Packages.tesserocr python38Packages.tesserocr
@GrahamcOfBorg build python27Packages.tesserocr python37Packages.tesserocr python38Packages.tesserocr |
can you mark this as linux only? unless you want to trouble shoot why darwin is failing on dlopen |
b4b5934
to
8882201
Compare
8882201
to
9575de7
Compare
@GrahamcOfBorg build python27Packages.tesserocr python37Packages.tesserocr python38Packages.tesserocr |
LGTM |
Motivation for this change
This is an attempt of adding tesserocr to nixpkgs, there are already some wrappers for tesseract in
nixpkgs
, but I need this one and it seems there's no derivation yet (so I put myself as maintainer).Any comments on this derivation are always welcome. I'm currently not sure on how to test a python library, but the derivation compiles.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @