Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hruby by adding ruby_2_1 dependency #7442

Closed
wants to merge 1 commit into from
Closed

Fix hruby by adding ruby_2_1 dependency #7442

wants to merge 1 commit into from

Conversation

PierreR
Copy link
Contributor

@PierreR PierreR commented Apr 18, 2015

This works locally with the current default ghc (still 7.8.4)

I had to disable testing as it cannot find the test ruby file

PS: I haven't figured out how to enable the package back into the hydra system as it is currently disabled.

@jagajaga
Copy link
Member

сс @peti

@PierreR
Copy link
Contributor Author

PierreR commented Apr 19, 2015

Just check it with 7.10.1 (that is now the default in the master branch) and it works fine as well.

@jagajaga
Copy link
Member

That's a wrong way to fix haskell pkgs. Let's wait for @peti's answer.

peti added a commit to NixOS/cabal2nix that referenced this pull request Apr 19, 2015
@peti
Copy link
Member

peti commented Apr 19, 2015

@PierreR, thank you for the fixes. I've added appropriate overrides in peti@e83e110. I'll merge to master as soon as the test builds are done.

The Hydra builds are controlled by cabal2nix. NixOS/cabal2nix@a6a28c6 enables them for hruby again.

@peti peti closed this Apr 19, 2015
peti added a commit to peti/nixpkgs that referenced this pull request Apr 19, 2015
@PierreR
Copy link
Contributor Author

PierreR commented Apr 20, 2015

@peti Thanks. I have learned a lot from your fix ;-)

The tests are actually failing because it does not find a test ruby file ?

Do you know how to fix this ? Add it as an extra files in cabal would do the job ?

@peti
Copy link
Member

peti commented Apr 20, 2015

@PierreR, yes, the file was missing from the release tarball. This problem was fixed upstream in bartavelle/hruby@22785b8 (by adding an extra-files: stanza).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants