Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.ipv6: port to python #74758

Merged
merged 2 commits into from Dec 9, 2019
Merged

nixosTests.ipv6: port to python #74758

merged 2 commits into from Dec 9, 2019

Conversation

@mmilata
Copy link
Contributor

mmilata commented Dec 1, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.
f"[ `ip -o -6 addr show dev {iface} scope {scope} | grep -v tentative | wc -l` -ge 1 ]"
)
output = machine.succeed(f"ip -o -6 addr show dev {iface} scope {scope}")
ip = re.split(r"[ /]+", output)[3]

This comment has been minimized.

Copy link
@tfc

tfc Dec 1, 2019

Contributor

wouldn't it be more direct and stable to match out the group of the subtext that looks like an ip (four numbers separated by dots)?

nixos/tests/ipv6.nix Outdated Show resolved Hide resolved
nixos/tests/ipv6.nix Outdated Show resolved Hide resolved
nixos/tests/ipv6.nix Outdated Show resolved Hide resolved
@mmilata mmilata force-pushed the mmilata:ipv6-python-test branch from 292c9c4 to 55c79bf Dec 1, 2019
@mmilata

This comment has been minimized.

Copy link
Contributor Author

mmilata commented Dec 1, 2019

I've changed the test according to suggestions but noticed it randomly failing. It's possible that I broke it during the conversion, looking into this ...

@mmilata mmilata force-pushed the mmilata:ipv6-python-test branch from 55c79bf to d65ffa3 Dec 8, 2019
wait_for_address sometimes returned tentative address.
@mmilata mmilata force-pushed the mmilata:ipv6-python-test branch from d65ffa3 to 6ebf84a Dec 8, 2019
@mmilata

This comment has been minimized.

Copy link
Contributor Author

mmilata commented Dec 8, 2019

The problem was in the original test which sometimes ended up using tentative address. Should be fixed now, PTAL.

cc @tfc @flokli @lheckemann

@lheckemann

This comment has been minimized.

Copy link
Member

lheckemann commented Dec 9, 2019

@ofborg test ipv6

@flokli flokli merged commit a29e850 into NixOS:master Dec 9, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.ipv6 on aarch64-linux Success
Details
tests.ipv6 on x86_64-linux Success
Details
@mmilata mmilata deleted the mmilata:ipv6-python-test branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.