pythonPackages.numpy: consistent mklSupport attribute #74894
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
numpy
respect themklSupport
boolean attribute that is inuse in
pytorch
and other packages that have an MKL option.While most packages that have this option depend on Numpy directly or
transitively, not all do; and it's more straightforward to have one config
option, since we generally want this to be applied consistently across our
library stack.
Note that this change as implemented should be backwards-compatible with the
previous numpy method for specifying MKL.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @FRidh @jonringer @alexarice @stites @markuskowa @smaret @costrouc @Ericson2314