Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.polyline: init at 1.4.0 #75071

Merged
merged 2 commits into from Dec 6, 2019

Conversation

@earksiinni
Copy link
Contributor

@earksiinni earksiinni commented Dec 5, 2019

Motivation for this change

Add polyline Python package (needed to support Mapbox Python SDK).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

N/A

@earksiinni earksiinni requested review from FRidh and jonringer as code owners Dec 5, 2019
@earksiinni earksiinni changed the title polyline: init at 1.4.0 pythonPackages.polyline: init at 1.4.0 Dec 5, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 5, 2019
@earksiinni earksiinni force-pushed the earksiinni:ersin/python-polyline branch from 03d8e51 to dfd411e Dec 5, 2019
@earksiinni
Copy link
Contributor Author

@earksiinni earksiinni commented Dec 6, 2019

I've updated this PR with your suggestions, @jonringer. Thanks for your help!

@earksiinni earksiinni requested a review from jonringer Dec 6, 2019
Copy link
Contributor

@jonringer jonringer left a comment

please squash the commits, should only be two:

maintainers: add ersin
pythonPackages.polyline: init at 1.4.0
earksiinni added 2 commits Dec 5, 2019
Add polyline Python package (needed to support Mapbox Python SDK).
@earksiinni earksiinni force-pushed the earksiinni:ersin/python-polyline branch from b21128e to 41ff7d9 Dec 6, 2019
@earksiinni
Copy link
Contributor Author

@earksiinni earksiinni commented Dec 6, 2019

@jonringer done!

@earksiinni earksiinni requested a review from jonringer Dec 6, 2019
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM
repo LGTM

https://github.com/NixOS/nixpkgs/pull/75071
3 package were built:
python27Packages.polyline python37Packages.polyline python38Packages.polyline
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 6, 2019

@GrahamcOfBorg build python27Packages.polyline python37Packages.polyline python38Packages.polyline

@jonringer jonringer merged commit 7d17a24 into NixOS:master Dec 6, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.polyline, python37Packages.polyline, python38Packages.polyline on aarch64-linux Success
Details
python27Packages.polyline, python37Packages.polyline, python38Packages.polyline on x86_64-darwin Success
Details
python27Packages.polyline, python37Packages.polyline, python38Packages.polyline on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.