-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swt: 4.5 -> 4.14 #75609
swt: 4.5 -> 4.14 #75609
Conversation
Thank you for your investigation @doronbehar. Much appreciated. I am currently really busy, but I will try to look into this. |
Oh right, it seems that the main issue was to find the latest version - 4.14 according to this page and the default build procedure seems to work for this version just like the old ones. Yet, that swt based program I tried to run with this version installed failed with:
Not sure what that means, but most probably, that the latest swt isn't compatible with this program and it's unmaintained so screw it... Anyway, swt seems to be updated now. @pSub do you know how to test all packages that depend on swt with this update? |
Remove other x86 unsupported platform. Add gtk3 as a dependency.
9c0e0a6
to
31e0d83
Compare
I tested this with nix-review:
However this does not fix #76168 for me, and it does not seem like the swt package is used in any way by JDK or Eclipse. |
The way it is this breaks some applications. Vuze fails with the following error:
I was not able to fix this error, even after removing gtk3 from buildInputs again it still persists. |
I see. TBH I've lost interest in this update, maybe we should create a |
I got to a similar NPE using
To me tuxguitar is currently broken after an nixpkgs/home-manager update, so I'd rather have it broken with the nullptr, than with a library incompatibility and terminating right away, it feels that this is a step in the right direction anyways and maybe having a |
I marked this as stale due to inactivity. → More info |
I don't know if this PR is worth something, not to me anyway. Closing. |
Motivation for this change
swt 4.5 is outdated since 2015 (!). Moreover, it's GTK2 compatibility is with gtk 2.18, meaning running something depending on our swt with gtk 2.24.32 will spit out errors such as:
See also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=476644
Related PR: #59999 .
BTW #30826 should be closed.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)I've tried switching over to the source tarball upstream provides (see the bottom link here) but the build failed because what's in
src.zip
is completely different then what's in that tarball, download the source table and see for your self.EDIT:
Maintainers: cc @pSub