New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-synapse: 1.7.0 -> 1.7.1 #75860
Conversation
Btw should we backport 1.7.x to |
The linked release note says:
So yes, we have to backport this @Ma27. |
@ofborg test matrix-synapse (Can we enable automatic testing with NixOS tests for this package?) |
Ok I missed the "all synapse versions are affected part", sorry! 🤦♂️ As soon as this is reviewed by some more folks, I'll merge and backport! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ma27 the changes seem okay. Feel free to merge.
@pacien (Can we enable automatic testing with NixOS tests for this package?) This would be something like adding I planned to do that someday (as well as for all other nixos tests), but have been under the water for more than a year… :( feel free to submit a PR with changes like that! (that said, for it to actually work, we'll have to wait for NixOS/ofborg#410 to get merged and deployed) |
As proposed during the last matrix-synapse bump[1]. [1] #75860 (comment)
As this pattern seems to be a thing now, I added this to matrix-synapse as well: e4b9156 |
\o/ thank you! |
As proposed during the last matrix-synapse bump[1]. [1] NixOS#75860 (comment) (cherry picked from commit e4b9156)
Motivation for this change
https://github.com/matrix-org/synapse/releases/tag/v1.7.1
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)