Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trenchbroom: init at 2019.6 #76607

Closed
wants to merge 2 commits into from
Closed

trenchbroom: init at 2019.6 #76607

wants to merge 2 commits into from

Conversation

@ranguli
Copy link

@ranguli ranguli commented Dec 28, 2019

Motivation for this change

This is my first NixOS package, so any constructive feedback would be greatly appreciated!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@stigtsp stigtsp left a comment

Some feedback:

Missing reference to pkg in pkgs/top-level/all-packages.nix


meta = with stdenv.lib; {
description = "TrenchBroom is a modern cross-platform level editor for Quake-engine based games";
homepage = http://kristianduske.com/trenchbroom;
Copy link
Member

@stigtsp stigtsp Jan 6, 2020

Please quote the URL NixOS/rfcs#45

Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 29, 2020

Suggested change
homepage = http://kristianduske.com/trenchbroom;
homepage = "http://kristianduske.com/trenchbroom";

cmakeFlags = [ "-DwxWidgets_PREFIX=${wxGTK31}" ];
hardeningDisable = [ "format" ];

postInstall = "mkdir $out/share/applications; ln -s ../TrenchBroom/trenchbroom.desktop $out/share/applications";
Copy link
Member

@stigtsp stigtsp Jan 6, 2020

  • Use multi line syntax for the postInstall script
  • Consider using cp or install instead of ln

pname = "TrenchBroom";
version = "2019.6";

src = fetchgit {
Copy link
Member

@stigtsp stigtsp Jan 6, 2020

use fetchFromGitHub

@stale
Copy link

@stale stale bot commented Jul 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale label Jul 4, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Aug 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-run-qt-apps-on-a-build-time-trying-to-pack-trenchbroom/8451/1

@stale stale bot removed the 2.status: stale label Aug 5, 2020
};

buildInputs = [ mesa mesa_glu freeimage freetype pandoc wxGTK31 libX11 ];
nativeBuildInputs = [ cmake git ];
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 29, 2020

Suggested change
nativeBuildInputs = [ cmake git ];
nativeBuildInputs = [ cmake ];

If git is fetching some info about the repo please patch that.

cmakeFlags = [ "-DwxWidgets_PREFIX=${wxGTK31}" ];
hardeningDisable = [ "format" ];

postInstall = "mkdir $out/share/applications; ln -s ../TrenchBroom/trenchbroom.desktop $out/share/applications";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 29, 2020

Suggested change
postInstall = "mkdir $out/share/applications; ln -s ../TrenchBroom/trenchbroom.desktop $out/share/applications";
postInstall = ''
mkdir $out/share/applications
cp ../TrenchBroom/trenchbroom.desktop $out/share/applications
'';


meta = with stdenv.lib; {
description = "TrenchBroom is a modern cross-platform level editor for Quake-engine based games";
homepage = http://kristianduske.com/trenchbroom;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 29, 2020

Suggested change
homepage = http://kristianduske.com/trenchbroom;
homepage = "http://kristianduske.com/trenchbroom";

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Closing since author did not respond since opening this almost a year ago. Please fix the review comments and ping me and I'll reopen the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants