Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.compiledb: init at 0.10.1 + dependencies #76654

Merged
merged 3 commits into from Jan 3, 2020

Conversation

@multun
Copy link
Member

@multun multun commented Dec 29, 2019

Motivation for this change

I need compiledb to run some proprietary software

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@multun multun requested review from FRidh and jonringer as code owners Dec 29, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 29, 2019
@multun multun force-pushed the multun:compiledb branch 2 times, most recently from 55bccd8 to 21d5874 Dec 29, 2019
@multun
Copy link
Member Author

@multun multun commented Dec 29, 2019

@costrouc thanks for the review :)

@costrouc
Copy link
Contributor

@costrouc costrouc commented Dec 29, 2019

Nix review passes. Would still like to see that package names alphabetized in python-packages.nix. Otherwise LGTM.

Result of nix-review pr 76654 1

9 package were built:
  • python27Packages.bashlex
  • python27Packages.compiledb
  • python27Packages.shutilwhich
  • python37Packages.bashlex
  • python37Packages.compiledb
  • python37Packages.shutilwhich
  • python38Packages.bashlex
  • python38Packages.compiledb
  • python38Packages.shutilwhich
@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 1, 2020

Neat, thanks for the PR!

Kicking the tires a bit, noticed something that seems undesired:

$ /nix/store/f0191y6jz8zqcx119yvy9xs2by9nd8xj-python3.7-compiledb-0.10.1/bin/compiledb --help
Unable to create '/nix/store/3isgyj3nyp7zjsp4i6np1q1fxqyrsw49-python3.7-bashlex-0.14/lib/python3.7/site-packages/bashlex/parsetab.py'
[Errno 30] Read-only file system: '/nix/store/3isgyj3nyp7zjsp4i6np1q1fxqyrsw49-python3.7-bashlex-0.14/lib/python3.7/site-packages/bashlex/parsetab.py'

Is this a problem, can it be fixed?

@multun
Copy link
Member Author

@multun multun commented Jan 1, 2020

@dtzWill it's not a huge problem but there's definitely room for improvement here. I'll fix it

@multun multun force-pushed the multun:compiledb branch from 21d5874 to 7eed7e3 Jan 1, 2020
@multun
Copy link
Member Author

@multun multun commented Jan 2, 2020

@dtzWill the warning shouldn't be there anymore, thanks for the report :)

@multun multun force-pushed the multun:compiledb branch from 7eed7e3 to d751f3f Jan 2, 2020
@multun
Copy link
Member Author

@multun multun commented Jan 2, 2020

Would still like to see that package names alphabetized in python-packages.nix. Otherwise LGTM.

Done, thanks!

@multun multun force-pushed the multun:compiledb branch from d751f3f to 6269578 Jan 2, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM
has tests for each package 👍
repo's look active enough

[13 built, 5 copied (1.0 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76654
9 package built:
python27Packages.bashlex python27Packages.compiledb python27Packages.shutilwhich python37Packages.bashlex python37Packages.compiledb python37Packages.shutilwhich python38Packages.bashlex python38Packages.compiledb python38Packages.shutilwhich
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 3, 2020

@GrahamcOfBorg build python27Packages.bashlex python27Packages.compiledb python27Packages.shutilwhich python37Packages.bashlex python37Packages.compiledb python37Packages.shutilwhich python38Packages.bashlex python38Packages.compiledb python38Packages.shutilwhich

@jonringer jonringer merged commit 16c6659 into NixOS:master Jan 3, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.bashlex, python27Packages.compiledb, python27Packages.shutilwhich, python37Packages.bashlex, python37Packages.compiledb, python37Packages.shutilwhich, python38Packages.bashlex, python38Packages.compiledb, python38Packages.shutilwhich on aarch64-linux Success
Details
python27Packages.bashlex, python27Packages.compiledb, python27Packages.shutilwhich, python37Packages.bashlex, python37Packages.compiledb, python37Packages.shutilwhich, python38Packages.bashlex, python38Packages.compiledb, python38Packages.shutilwhich on x86_64-darwin Success
Details
python27Packages.bashlex, python27Packages.compiledb, python27Packages.shutilwhich, python37Packages.bashlex, python37Packages.compiledb, python37Packages.shutilwhich, python38Packages.bashlex, python38Packages.compiledb, python38Packages.shutilwhich on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.