-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.compiledb: init at 0.10.1 + dependencies #76654
Conversation
55bccd8
to
21d5874
Compare
@costrouc thanks for the review :) |
Nix review passes. Would still like to see that package names alphabetized in python-packages.nix. Otherwise LGTM. Result of 9 package were built:
|
Neat, thanks for the PR! Kicking the tires a bit, noticed something that seems undesired: $ /nix/store/f0191y6jz8zqcx119yvy9xs2by9nd8xj-python3.7-compiledb-0.10.1/bin/compiledb --help
Unable to create '/nix/store/3isgyj3nyp7zjsp4i6np1q1fxqyrsw49-python3.7-bashlex-0.14/lib/python3.7/site-packages/bashlex/parsetab.py'
[Errno 30] Read-only file system: '/nix/store/3isgyj3nyp7zjsp4i6np1q1fxqyrsw49-python3.7-bashlex-0.14/lib/python3.7/site-packages/bashlex/parsetab.py' Is this a problem, can it be fixed? |
@dtzWill it's not a huge problem but there's definitely room for improvement here. I'll fix it |
@dtzWill the warning shouldn't be there anymore, thanks for the report :) |
Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
has tests for each package 👍
repo's look active enough
[13 built, 5 copied (1.0 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76654
9 package built:
python27Packages.bashlex python27Packages.compiledb python27Packages.shutilwhich python37Packages.bashlex python37Packages.compiledb python37Packages.shutilwhich python38Packages.bashlex python38Packages.compiledb python38Packages.shutilwhich
@GrahamcOfBorg build python27Packages.bashlex python27Packages.compiledb python27Packages.shutilwhich python37Packages.bashlex python37Packages.compiledb python37Packages.shutilwhich python38Packages.bashlex python38Packages.compiledb python38Packages.shutilwhich |
Motivation for this change
I need compiledb to run some proprietary software
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @