Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.srsly: 0.2.0 -> 1.0.1 #77600

Merged
merged 1 commit into from Jan 13, 2020
Merged

Conversation

@danieldk
Copy link
Member

@danieldk danieldk commented Jan 13, 2020

Motivation for this change

srsly 2.0.0 is also released. But since spaCy/textacy are the only
dependencies and spaCy requires < 1.1.0, it probably makes more sense
to bump this to 1.0.1 for the time being.

And additional argument in favor of 1.0.1 is that 2.0.0 drops support
for Python 3.5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
srsly 2.0.0 is also released. But since spaCy/textacy are the only
dependencies and spaCy requires < 1.1.0, it probably makes more sense
to bump this to 1.0.1 for the time being.

And additional argument in favor of 1.0.1 is that 2.0.0 drops support
for Python 3.5.
@danieldk danieldk requested review from FRidh and jonringer as code owners Jan 13, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

python38 failures unrelated to PR

[9 built (1 failed), 43 copied (84.2 MiB), 21.0 MiB DL]
error: build of '/nix/store/9fsgvhablls8vrkzzpmzhjsmm2jbymbf-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77600
2 package failed to build:
python38Packages.spacy python38Packages.textacy

8 package built:
python27Packages.srsly python27Packages.thinc python37Packages.spacy python37Packages.srsly python37Packages.textacy python37Packages.thinc python38Packages.srsly python38Packages.thinc
@jonringer jonringer merged commit 7269a92 into NixOS:master Jan 13, 2020
@danieldk danieldk deleted the danieldk:srsly-1.0.1 branch Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.