Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainer-list.nix #77615

Closed
wants to merge 1 commit into from
Closed

Update maintainer-list.nix #77615

wants to merge 1 commit into from

Conversation

@gnidorah
Copy link
Contributor

@gnidorah gnidorah commented Jan 13, 2020

Update my e-mail

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Update my e-mail
@alyssais
Copy link
Member

@alyssais alyssais commented Jan 13, 2020

This does not look like an accurate email address at which you can be reached…

@gnidorah
Copy link
Contributor Author

@gnidorah gnidorah commented Jan 13, 2020

@alyssais
Hm, there are already some users.noreply.github.com emails in maintainer-list.nix, so I thought its legal.

Anyway, I prefer to be contacted via GitHub...

@alyssais
Copy link
Member

@alyssais alyssais commented Jan 13, 2020

I’m not sure what the email field is actually used for nowadays, but I assume it’s a required field for a reason, and so I don’t think circumventing it with a fake address is a good idea.

I’d like to get clarification on whether we need to be requiring email addresses at all, but until then, I don’t think fake email addresses should be used…

@alyssais
Copy link
Member

@alyssais alyssais commented Jan 13, 2020

It’s important that there be some way to contact maintainers privately if necessary. If you don’t want to use the email address currently in maintainer-list.nix for that, please replace it with a different one that could be used instead.

Additionally, your current email address in that list will of course remain in the git history forever, for what it’s worth.

@gnidorah
Copy link
Contributor Author

@gnidorah gnidorah commented Jan 13, 2020

@alyssais Ok, thank you!

@gnidorah gnidorah closed this Jan 13, 2020
@gnidorah gnidorah deleted the gnidorah:patch-1 branch Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.