Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aview: new at 1.3.0rc1-debian4 #77711

Closed
wants to merge 1 commit into from
Closed

aview: new at 1.3.0rc1-debian4 #77711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions pkgs/applications/graphics/aview/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{ lib, stdenv, fetchFromGitHub, aalib, ncurses }:

stdenv.mkDerivation rec {
pname = "aview";
version = "1.3.0rc1-debian4";

src = fetchFromGitHub {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you choose your own fork for this? Upstream seems to point to sourceforge for source code download. If you'd like to advertise your own fork in NixOS, that's totally legit. Just name the package a little bit differently (maybe aview-deepfire) and change the homepage URL.

If your own fork in comparison with upstream is just a matter of a few bug fixes, it'd be a bit more pragmatic perhaps to use patches instead of a completely different fork.

Copy link
Contributor Author

@deepfire deepfire Sep 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project is dead and requires debian's patches to be applied -- which is the only thing I did: https://github.com/deepfire/aview/commits/master

You're right about patches though, @doronbehar, that'd be the better option.

owner = "deepfire";
repo = "aview";
rev = "c128170199aa3516649ad9ed806af30849f19ffc";
sha256 = "1gikxn2z12rfbb9vdf7pgrjk2kvr83bk1hycmijvdnbls6l87cyp";
};

buildInputs = [
aalib ncurses
];

meta = {
homepage = http://aa-project.sourceforge.net/;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = http://aa-project.sourceforge.net/;
homepage = "http://aa-project.sourceforge.net/aview/";

description = "Aview is a high quality ascii-art image(pnm) browser and animation(fli/flc) player.";
license = stdenv.lib.licenses.gpl2;
platforms = [ "x86_64-linux" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's not working / building on 32bit Linux ?

maintainers = [ lib.maintainers.deepfire ];
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18082,6 +18082,8 @@ in

autotrace = callPackage ../applications/graphics/autotrace {};

aview = callPackage ../applications/graphics/aview { };

avocode = callPackage ../applications/graphics/avocode {};

azpainter = callPackage ../applications/graphics/azpainter { };
Expand Down