Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mame: 0.217 -> 0.218 #80021

Merged
merged 1 commit into from Feb 13, 2020
Merged

mame: 0.217 -> 0.218 #80021

merged 1 commit into from Feb 13, 2020

Conversation

@qeeg
Copy link
Contributor

@qeeg qeeg commented Feb 13, 2020

Motivation for this change

Update the MAME package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

unable to build:

  Unable to open output file 'build/generated/mame/machine/mulcd.hxx'
  make: *** [makefile:1723: build/generated/mame/machine/mulcd.hxx] Error 255
cannot build derivation '/nix/store/56rwqr6rfh93jb3sysa66firfqjgc62m-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 2 copied (1.7 MiB), 0.2 MiB DL]
error: build of '/nix/store/56rwqr6rfh93jb3sysa66firfqjgc62m-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80021
1 package failed to build:
mame
@gnidorah
Copy link
Contributor

@gnidorah gnidorah commented Feb 13, 2020

Copy link
Contributor

@jonringer jonringer left a comment

ran review a second time, and it's fine.
Not sure if package has some flakiness, but not going to hold it against a version bump.

[2 built]
https://github.com/NixOS/nixpkgs/pull/80021
1 package built:
mame
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

gui opens fine

@jonringer jonringer merged commit 04fb02a into NixOS:master Feb 13, 2020
15 checks passed
15 checks passed
mame on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mame on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.