Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus: Merge dbus-library, dbus-tools and dbus-daemon into a single package #81

Closed
wants to merge 1 commit into from

Conversation

rickynils
Copy link
Member

I ran into a problem where an application (network-manager-applet) tried to execute dbus-launch from /nix/store/...dbus-library.../bin/dbus-launch, which doesn't exist, since the dbus-launch binary is built by the dbus-tools package. It turns out, however, that it is the dbus-library itself that refers to the dbus-launch binary (in its own bin dir). Since dbus-tools depends on dbus-library, this can't be fixed without introducing a circular dependency.

What do you say about merging dbus-library, dbus-tools and dbus-daemon (which already is equal to dbus-library) into one package?

Doing that solves the problem, and doesn't seem to cause any other problems. The only trouble I can imagine, is that some X11 dependencies are introduced in dbus-library:

buildInputs = [ expat ] ++ stdenv.lib.optionals useX11 [ libX11 libICE libSM ];

…ckage.

This overcomes problems with circular dependencies between dbus-library and dbus-tools.
@7c6f434c
Copy link
Member

7c6f434c commented Aug 1, 2012

I think that merging dbus-* is a good idea

@edolstra
Copy link
Member

edolstra commented Aug 1, 2012

They are split to prevent a dependency on X11 in applications that require the dbus libraries. So we shouldn't merge them.

In the future we can probably use a single dbus package with multiple outputs to handle this.

@edolstra edolstra closed this Aug 1, 2012
@vcunat
Copy link
Member

vcunat commented Aug 1, 2012

Closed, well, but what about the circular dependency, or do we have another solution to the described problem?

@rickynils
Copy link
Member Author

Yes, I also wonder what we should do in the meantime... I have
NetworkManager applet working nicely on my computer now with the dbus
merge, but I haven't found a way to solve the issue in another way.

Den 2012-08-01 20:52:10 skrev Vladimír Čunát
reply@reply.github.com:

Closed, well, but what about the circular dependency, or do we have
another solution to the described problem?


Reply to this email directly or view it on GitHub:
#81 (comment)

@rickynils rickynils deleted the dbus branch October 19, 2014 14:57
shlevy pushed a commit to shlevy/nixpkgs that referenced this pull request Feb 9, 2018
ghc 8.{2,4}: Add patches for deterministic profiling symbols.
@veprbl veprbl mentioned this pull request May 31, 2020
10 tasks
Profpatsch pushed a commit that referenced this pull request Jun 20, 2020
ethancedwards8 pushed a commit to ethancedwards8/nixpkgs that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants