Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prusa-slicer: 2.1.1 -> 2.2.0 #82551

Merged
merged 1 commit into from Mar 31, 2020
Merged

prusa-slicer: 2.1.1 -> 2.2.0 #82551

merged 1 commit into from Mar 31, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Mar 14, 2020 •
edited

Motivation for this change

Update to latest version, 2.2.0. Several new dependencies and a bit of cleanup.

cc @mweinelt @ArdaXi @baracoder @thorstenweber83 as you were interested in the previous PRs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread

This comment has been minimized.

Sign in to view
@Moredread Moredread changed the title prusa-slicer: 2.2.0 preperations prusa-slicer: 2.2.0 preparations Mar 14, 2020
@Moredread

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member

mweinelt commented Mar 14, 2020 •
edited

Tested through nixpkgs-review pr and saw no compilation issues. Did a quick run test and things looked fine, but I don't have access to our 3D printer currently, since we shutdown our hackerspace during this crisis.

@Moredread Moredread changed the title prusa-slicer: 2.2.0 preparations prusa-slicer: 2.2.0-rc3 in preparation for 2.2.0 Mar 14, 2020
@Moredread Moredread changed the title prusa-slicer: 2.2.0-rc3 in preparation for 2.2.0 prusa-slicer: 2.2.0-rc4 in preparation for 2.2.0 Mar 15, 2020
@Moredread Moredread force-pushed the slicer branch 2 times, most recently from da64b9a to 9887d8a Compare March 21, 2020 14:24
@Moredread Moredread changed the title prusa-slicer: 2.2.0-rc4 in preparation for 2.2.0 prusa-slicer: 2.1.1 -> 2.2.0 Mar 23, 2020
@Moredread
Copy link
Contributor Author

@GrahamcOfBorg build prusa-slicer

@Moredread Moredread marked this pull request as ready for review March 23, 2020 11:45
@Moredread
Copy link
Contributor Author

@mweinelt can you have a look again please, now that the final release is up?

@mweinelt
Copy link
Member

Building looks good, when starting I immediately get

[2020-03-23 14:36:05.454724] [0x00007f88637fe700] [error]   Unable to initialize hidapi library: failed to load libudev.so.1 or libudev.so.0

Does that affect the USB connection to the printer? I don't know yet.

Everything else looks fine to me.

@Moredread
Copy link
Contributor Author

@mweinelt I'm not sure, that is new I think. I also don't have a printer atm.

@Moredread
Copy link
Contributor Author

I think it works now. :)

Moredread referenced this pull request in nix-community/nur-combined Mar 30, 2020
@nur-bot
moredread: 6b69c45da8 -> cd7ceb6fb8
ca5a7a5
@Mic92
Copy link
Member

Mic92 commented Mar 30, 2020

@mweinelt can you test again?

@mweinelt
Copy link
Member

Yep, error is gone. Everything else lgtm.

@Moredread
prusa-slicer: 2.1.1 -> 2.2.0
bbce57b 
Adding myself (moredread) as maintainer. Several new dependencies and a bit of cleanup.
@Mic92 Mic92 merged commit 84ad3f2 into NixOS:master Mar 31, 2020
@Moredread Moredread deleted the slicer branch March 31, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @mweinelt @Mic92