Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1-haskell: unbreak via override #82562

Merged
merged 1 commit into from Mar 20, 2020

Conversation

jtobin
Copy link
Contributor

@jtobin jtobin commented Mar 14, 2020

This library simply needs libsecp256k1 in its pkgconfig-depends.

Motivation for this change

Unbreaks the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This library simply needs libsecp256k1 in its pkgconfig-depends.
@cdepillabout
Copy link
Member

@jtobin Thanks for looking into this.

Can you instead fix this in cabal2nix? That way we can have pkgs.secp256k1 set correctly for all Haskell packages that use it.

@jtobin
Copy link
Contributor Author

jtobin commented Mar 14, 2020

@cdepillabout PR made, see NixOS/cabal2nix#444.

What's the best thing to now do here? Rebase away the changes in configuration-nix.nix?

@jtobin
Copy link
Contributor Author

jtobin commented Mar 14, 2020

Rebase away the changes in configuration-nix.nix?

(And ditto for #82563.)

@cdepillabout
Copy link
Member

What's the best thing to now do here? Rebase away the changes in configuration-nix.nix?

How about waiting for a week or so for peti to merge in the change in NixOS/cabal2nix#444 and release a new version of hackage2nix.

When that happens, please rebase this PR and just leave the part that marks the package unbroken. (You could also just combine your two open PRs into one to make it easier to keep track of.)

If the above PR doesn't get merged within a week or so, please feel free to ping me one more time on this PR and I will go ahead and merge it in as-is.

@jtobin
Copy link
Contributor Author

jtobin commented Mar 15, 2020

All good, will do. Cheers.

@peti peti merged commit e1408eb into NixOS:haskell-updates Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants