Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: 1.1.1d -> 1.1.1e #82789

Closed
wants to merge 1 commit into from
Closed

openssl: 1.1.1d -> 1.1.1e #82789

wants to merge 1 commit into from

Conversation

@andir
Copy link
Member

andir commented Mar 17, 2020

Motivation for this change

a "Low severity" [0] security issue:

Fixed an overflow bug in the x64_64 Montgomery squaring procedure used
in exponentiation with 512-bit moduli (CVE-2019-1551)

[0] https://www.openssl.org/news/vulnerabilities.html#y2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
a "Low severity" [0] security issue:

> Fixed an overflow bug in the x64_64 Montgomery squaring procedure used
> in exponentiation with 512-bit moduli (CVE-2019-1551)

[0] https://www.openssl.org/news/vulnerabilities.html#y2019
@xfix
xfix approved these changes Mar 17, 2020
@vcunat
Copy link
Member

vcunat commented Mar 23, 2020

Even current staging (db1eb19) still suffers from the same issue as 19.09, so this can't be merged as-is.

@flokli flokli mentioned this pull request Apr 2, 2020
0 of 10 tasks complete
@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

To recap: pyopenssl fails to build with that, upstream tracking issue is in pyca/pyopenssl#899.

I'll file PRs applying just the CVE-fixing patch. We can probably still "properly" bump openssl as soon as pyopenssl has updated their code.

@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

Opened PRs to backport the fix for CVE-2019-1551 to master and 20.03 (staging):
#84083
#84084

Copy link
Contributor

xfix left a comment

Please update to 1.1.1f. It's like 1.1.1e, but without EOF change (see https://www.openssl.org/news/openssl-1.1.1-notes.html).

@vcunat vcunat self-assigned this Apr 2, 2020
@flokli flokli mentioned this pull request Apr 2, 2020
0 of 10 tasks complete
@vcunat
Copy link
Member

vcunat commented Apr 2, 2020

Pushed as 6c8692f

@vcunat vcunat closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.