-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve robustness of various Rust packages #82982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
cole-h
changed the title
improve robustness of installPhase of various Rust packages
improve robustness of various Rust packages
Mar 20, 2020
Ma27
approved these changes
Mar 26, 2020
I accidentally removed the |
@ofborg build ripgrep zcash lsd (Testing recent ofborg deploy.) |
Thanks for taking care of this! Did some local tests and your changes seem fine now 👍 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some cleanup in preparation for #82342.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)@Ma27 I cherry-picked your
librustzcash
fix and reworded the commit message to slightly decouple it from #82342.I built and ran all of these packages by running
{binary} --help
. They all displayed their help flags at least (except forcfdyndns
, which panicked without some env vars set).@bhipple A few of the packages that showed up in
git grep target/release
actually need it (or, at least, don't benefit from it being changed to$releaseDir
). Just figured I'd let you know why I left outycmd
andvdirsyncer
.