Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsignal-protocol-c: 2.3.2 -> 2.3.3 #83736

Merged
merged 1 commit into from May 10, 2020

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented Mar 30, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libsignal-protocol-c/versions.

meta.description for libsignal-protocol-c is: "Signal Protocol C Library"

meta.homepage for libsignal-protocol-c is: "https://github.com/signalapp/libsignal-protocol-c"

Updates performed:

  • Version update
  • Quoted meta.homepage for RFC 45

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dino
libsignal-protocol-c
profanity
psi-plus

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4l55gfh3lm4m26x4ffjr5p267s3rylwn-libsignal-protocol-c-2.3.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libsignal-protocol-c https://github.com/r-ryantm/nixpkgs/archive/9304c984e291da1e2d2213446f7793ecf895d443.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4l55gfh3lm4m26x4ffjr5p267s3rylwn-libsignal-protocol-c-2.3.3
ls -la /nix/store/4l55gfh3lm4m26x4ffjr5p267s3rylwn-libsignal-protocol-c-2.3.3/bin

cc @orivej for testing.

Copy link
Contributor

jonringer left a comment

regression in dino

builder for '/nix/store/va1zd7662idn8fp8z5yjl8wpry93lisc-dino-0.1.0.drv' failed with exit code 1; last 10 log lines:
    required is exact version "2.3.2" (found
    /nix/store/jfzmm0xzrbd2agq1f3r4a71s3hg84bi7-libsignal-protocol-c-2.3.3/lib/libsignal-protocol-c.so)
  Call Stack (most recent call first):
    /nix/store/cmriqbxnpcgmbll06pnl1h3va08x2xvr-cmake-3.16.5/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:391 (_FPHSA_FAILURE_MESSAGE)
    cmake/FindSignalProtocol.cmake:9 (find_package_handle_standard_args)
    plugins/signal-protocol/CMakeLists.txt:35 (find_package)


  -- Configuring incomplete, errors occurred!
  See also "/build/source/build/CMakeFiles/CMakeOutput.log".
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
cannot build derivation '/nix/store/2798y07hqqykqnw38dkzfilxjnyq8cg0-env.drv': 1 dependencies couldn't be built
[4 built (1 failed), 13 copied (46.3 MiB), 20.9 MiB DL]
error: build of '/nix/store/2798y07hqqykqnw38dkzfilxjnyq8cg0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/83736
1 package failed to build:
dino

3 packages built:
libsignal-protocol-c profanity psi-plus
Luflosi added a commit to Luflosi/nixpkgs that referenced this pull request May 8, 2020
The exact version of libsignal-protocol-c used by dino is hard-coded to 2.3.2 because "libsignal-protocol-c has a history of breaking compatibility on the patch level". This prevents libsignal-protocol-c from being updated in NixOS#83736. To fix this, I do what the comment in plugins/signal-protocol/CMakeLists.txt recommends and what Arch Linux does (https://git.archlinux.org/svntogit/community.git/tree/trunk/signal-2.3.3.patch?h=packages/dino) and patch the source so that newer versions are allowed. This works fine for Arch Linux and for me.
@Luflosi Luflosi mentioned this pull request May 8, 2020
3 of 10 tasks complete
Luflosi added a commit to Luflosi/nixpkgs that referenced this pull request May 9, 2020
The exact version of libsignal-protocol-c used by dino is hard-coded to 2.3.2 because "libsignal-protocol-c has a history of breaking compatibility on the patch level". This prevents libsignal-protocol-c from being updated in NixOS#83736. Upstream already allows newer versions in the latest git master, so patch the source with this commit. Unfortunately patching doesn't work with git submodules but since the submodule is not used anyways, simply ignore this part of the patch.
@Luflosi
Copy link
Contributor

Luflosi commented May 10, 2020

@ryantm since #87283 has now been merged, could you revisit this PR please?

@ryantm
ryantm approved these changes May 10, 2020
@ryantm ryantm merged commit 91031a8 into NixOS:master May 10, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libsignal-protocol-c on aarch64-linux Success
Details
libsignal-protocol-c on x86_64-darwin Success
Details
libsignal-protocol-c on x86_64-linux Success
Details
@ryantm ryantm deleted the r-ryantm:auto-update/libsignal-protocol-c branch May 10, 2020
dashmoho pushed a commit to dashmoho/nixpkgs that referenced this pull request May 11, 2020
The exact version of libsignal-protocol-c used by dino is hard-coded to 2.3.2 because "libsignal-protocol-c has a history of breaking compatibility on the patch level". This prevents libsignal-protocol-c from being updated in NixOS#83736. Upstream already allows newer versions in the latest git master, so patch the source with this commit. Unfortunately patching doesn't work with git submodules but since the submodule is not used anyways, simply ignore this part of the patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.