Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babashka: 0.0.71 -> 0.0.78 #83776

Closed
wants to merge 8 commits into from
Closed

babashka: 0.0.71 -> 0.0.78 #83776

wants to merge 8 commits into from

Conversation

bhougland18
Copy link
Contributor

Motivation for this change

Add new package to repository. This is a small command line utility that allows one to use a subset of the clojure programming language in their shell commands.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trouble-with-creating-first-nix-package/6479/4

@AndersonTorres AndersonTorres changed the title add babashka babashka: init at 0.0.78 Mar 30, 2020
@AndersonTorres
Copy link
Member

Why is it failing the Borg?

@AndersonTorres AndersonTorres mentioned this pull request Mar 30, 2020
6 tasks
bhougland18 and others added 3 commits March 30, 2020 16:57
Co-Authored-By: Martin Milata <martin@martinmilata.cz>
Co-Authored-By: Anderson Torres <torres.anderson.85@protonmail.com>
Co-Authored-By: Anderson Torres <torres.anderson.85@protonmail.com>
@AndersonTorres AndersonTorres changed the title babashka: init at 0.0.78 babashka: 0.0.71 -> 0.0.78 Mar 31, 2020
@mmilata mmilata mentioned this pull request Mar 31, 2020
9 tasks
@bennyandresen
Copy link
Contributor

Maybe the location should be pkgs/development/interpreters/clojure/babashka.nix instead of pkgs/tools/misc/babashka/default.nix?

Anyway: looking forward to this package!

license = licenses.epl10;
platforms = graalvm8.meta.platforms;
maintainers = with maintainers; [ DerGuteMoritz ];
maintainers = with maintainers; [ bhougland jlesquembre DerGruteMoritz ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spelling of this maintainer is DerGuteMoritz

@bennyandresen
Copy link
Contributor

Not sure why eval fails by borg, but for me this PR builds fine and works as expected.

@mmilata @AndersonTorres

@bhougland18
Copy link
Contributor Author

Not sure why eval fails by borg, but for me this PR builds fine and works as expected.

@mmilata @AndersonTorres

I am currently using the software as well, works fine.

@bennyandresen
Copy link
Contributor

I would really like to see the latest babashka in NixOS, I would like to propose the following:

I resubmit a new PR, basically re-doing #83886 with the, I think, proper location of pkgs/development/interpreters/clojure/babashka.nix, based on master. I would use this PR's meta.description and meta.longDescription.

This PR has all its commits removed sans adding @bhougland18 to the maintainer list which can get merged then.
Then I will add @DerGuteMoritz, @bhougland18 & myself to the maintainers of this package in my new PR, so we can all keep an eye on new releases, graalvm updates affecting the package, etc.

Can we agree on this course of action @AndersonTorres and @bhougland18?

@bhougland18
Copy link
Contributor Author

bhougland18 commented Apr 3, 2020 via email

@AndersonTorres
Copy link
Member

OK for me.

In fact I was uploading a new diff for it now.

P.S.: I am a bit puristic, and I would like to ast two things:

  • Is it hard to compile directly from sources, instead of using a JAR file?
  • Can it be renamed as "babashka-jar"?

@AndersonTorres AndersonTorres mentioned this pull request Apr 4, 2020
10 tasks
@AndersonTorres
Copy link
Member

"Superceded" by #84284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants