Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar: optionally wrap mediaplayer.py #85507

Closed
wants to merge 1 commit into from
Closed

Conversation

@bbigras
Copy link
Contributor

bbigras commented Apr 18, 2020

Motivation for this change

waybar has a mediaplayer.py script that uses mpris to show the current song.

Things done

Quite a package closure size increase.

No idea if I should use preFixup or another phase.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/igjl73fjbg42hdk4di4bpjb6gypjx3cl-waybar-0.9.2 202.7M
/nix/store/sknk7z9mqbfsx25ijcvj23aw5c93fdwj-waybar-0.9.2 856.9M

@nixos-discourse
Copy link

nixos-discourse commented Apr 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/145

@bbigras bbigras force-pushed the bbigras:waybar branch from 8855400 to 2169649 Apr 22, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Apr 22, 2020

I made the change. Thanks.

@nixos-discourse
Copy link

nixos-discourse commented Apr 29, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/150

] ++ stdenv.lib.optional withMediaPlayer playerctl;

propagatedBuildInputs = stdenv.lib.optionals withMediaPlayer [
gobject-introspection

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Apr 29, 2020

Member

this should be native, and you'll need to set strictDeps = false; for it's setup hook to work properly.


propagatedBuildInputs = stdenv.lib.optionals withMediaPlayer [
gobject-introspection
python38Packages.pygobject3
];

buildInputs = with stdenv.lib;

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Apr 29, 2020

Member

you need to conditionally add glib because it uses it via gobject-introspection https://github.com/Alexays/Waybar/blob/master/resources/custom_modules/mediaplayer.py#L9

not sure where the playerctl module comes from

@bbigras bbigras force-pushed the bbigras:waybar branch from 2169649 to 050e660 Apr 30, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Apr 30, 2020

I made the changes. Thank you very much for your time.

@bbigras bbigras requested a review from worldofpeace May 6, 2020
@nixos-discourse
Copy link

nixos-discourse commented May 11, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/158

@bbigras bbigras force-pushed the bbigras:waybar branch from 050e660 to 0b5c9a7 May 18, 2020
@bbigras
Copy link
Contributor Author

bbigras commented May 18, 2020

holy shit. I'm sorry everyone. I clearly didn't push the right thing.

@bbigras bbigras mentioned this pull request May 18, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.