Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/texlive: Fix texlive pstricks #85736

Merged
merged 1 commit into from Apr 22, 2020
Merged

Conversation

immae
Copy link
Contributor

@immae immae commented Apr 22, 2020

Motivation for this change

The upgrade of ghostscript to 9.50 produced some issues with texlive 2019. This patch adds an additional fix necessary for the upgrade preventing pstricks from working correctly:

https://tug.org/pipermail/dvipdfmx/2019-November/000036.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@immae
Copy link
Contributor Author

immae commented Apr 22, 2020

The patch was tested and actually fixed the usecase that failed before

@ofborg ofborg bot added 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Apr 22, 2020
@immae immae force-pushed the fix_texlive_pstricks branch 3 times, most recently from 920d31d to 32c39c2 Compare April 22, 2020 09:02
The upgrade of ghostscript to 9.50 produced some issues with texlive
2019. This patch adds an additional fix necessary for the upgrade
preventing pstricks from working correctly:

  https://tug.org/pipermail/dvipdfmx/2019-November/000036.html
@veprbl
Copy link
Member

veprbl commented Apr 22, 2020

@GrahamcOfBorg build texlive.bin.dvisvgm

@immae
Copy link
Contributor Author

immae commented Apr 22, 2020

@veprbl : the patch is about xdvipdfmx, no dvisvgm (I guess you need to build texlive.bin.core then)

@veprbl
Copy link
Member

veprbl commented Apr 22, 2020

@GrahamcOfBorg build texlive.bin.core

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to resolve the issue with xetex + MRE from https://tug.org/pipermail/dvipdfmx/2019-November/000035.html

@veprbl veprbl merged commit 67d5cde into NixOS:master Apr 22, 2020
@veprbl
Copy link
Member

veprbl commented Apr 22, 2020

@immae Thank you!

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 22, 2020
@immae
Copy link
Contributor Author

immae commented Apr 22, 2020

Thanks @veprbl . I just saw your port to stable label, should I do a PR?

@veprbl
Copy link
Member

veprbl commented Apr 22, 2020

@immae No need, I'll take care of it.

@veprbl veprbl self-assigned this Apr 22, 2020
veprbl pushed a commit that referenced this pull request Apr 23, 2020
The upgrade of ghostscript to 9.50 produced some issues with texlive
2019. This patch adds an additional fix necessary for the upgrade
preventing pstricks from working correctly:

  https://tug.org/pipermail/dvipdfmx/2019-November/000036.html

(cherry picked from commit bb79233)
cc #85736

Conflicts:
	pkgs/tools/typesetting/tex/texlive/bin.nix
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 23, 2020
@veprbl veprbl removed their assignment Apr 23, 2020
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
The upgrade of ghostscript to 9.50 produced some issues with texlive
2019. This patch adds an additional fix necessary for the upgrade
preventing pstricks from working correctly:

  https://tug.org/pipermail/dvipdfmx/2019-November/000036.html

(cherry picked from commit bb79233)
cc NixOS#85736

Conflicts:
	pkgs/tools/typesetting/tex/texlive/bin.nix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: TeX Issues regarding texlive and TeX in general 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants