Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnnl: rename to oneDNN to track upstream project rename #85839

Merged
merged 1 commit into from May 6, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented Apr 23, 2020

See the link in the default.nix file for details. This adds an alias for
backwards compatibility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
See the link in the default.nix file for details.  This adds an alias for
backwards compatibility.
@bhipple
Copy link
Contributor Author

bhipple commented Apr 23, 2020

@GrahamcOfBorg build oneDNN dnnl

@bhipple
Copy link
Contributor Author

bhipple commented May 2, 2020

@markuskowa
Copy link
Member

markuskowa commented May 3, 2020

Depending on how widely used the libraray is, you could either make an entry in pkgs/top-level/aliases.nix or add a line to the release notes.

@bhipple
Copy link
Contributor Author

bhipple commented May 6, 2020

We have an alias here, so that should be fine.

@markuskowa markuskowa merged commit e231564 into NixOS:master May 6, 2020
16 checks passed
16 checks passed
dnnl, oneDNN on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
dnnl, oneDNN on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bab9dab"; rev="bab9dabd64df4cfa2d96c1d2abfb05ff7431420a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bhipple bhipple deleted the bhipple:u/dnnl-oneDNN branch Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.