Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.powerline: Added fish binding #86874

Merged
merged 1 commit into from May 6, 2020
Merged

Conversation

@justin-gerhardt
Copy link
Contributor

justin-gerhardt commented May 5, 2020

Motivation for this change

Adding the fish shell integration
Should allow use by invoking the powerline-setup function from fish

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

please take a look at https://nixos.org/nixpkgs/manual/ under the installShellfiles section

install -dm755 "$out/share/fish/vendor_functions.d"
install -m644 "powerline/bindings/fish/powerline-setup.fish" "$out/share/fish/vendor_functions.d/powerline-setup.fish"
Comment on lines +41 to +42

This comment has been minimized.

Copy link
@jonringer

jonringer May 5, 2020

Contributor
Suggested change
install -dm755 "$out/share/fish/vendor_functions.d"
install -m644 "powerline/bindings/fish/powerline-setup.fish" "$out/share/fish/vendor_functions.d/powerline-setup.fish"
installShellCompletion powerline/bindings/fish/powerline-setup.fish

... else where

nativeBuildInputs = [ installShellFiles ];

This comment has been minimized.

Copy link
@justin-gerhardt

justin-gerhardt May 5, 2020

Author Contributor

I had seen that, however installShellCompletion can't be used in this case. The integration has to be installed to vendor_functions.d and not vendor_completions.d, as Powerline provides a function not a completion. I don't see any helper functions for installing functions.

This comment has been minimized.

Copy link
@jonringer

jonringer May 6, 2020

Contributor

ah, I see. okay then

@justin-gerhardt justin-gerhardt changed the title pythonPackages.powerline: Added file binding pythonPackages.powerline: Added fish binding May 5, 2020
@justin-gerhardt justin-gerhardt requested a review from jonringer May 5, 2020
Copy link
Contributor

jonringer left a comment

diff LGTM

@jonringer jonringer merged commit 840b5bf into NixOS:master May 6, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7208fa1"; rev="7208fa18dce7f95b2df6690ea4553efbfb8124bf"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

jonringer commented May 6, 2020

@justin-gerhardt congrats on your first PR to nixpkgs! :)

@justin-gerhardt justin-gerhardt deleted the justin-gerhardt:patch-1 branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.