Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.powerline: Added fish binding #86874

Merged
merged 1 commit into from
May 6, 2020
Merged

pythonPackages.powerline: Added fish binding #86874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/development/python-modules/powerline/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ buildPythonPackage rec {

install -dm755 "$out/share/tmux"
install -m644 "powerline/bindings/tmux/powerline.conf" "$out/share/tmux/powerline.conf"

install -dm755 "$out/share/fish/vendor_functions.d"
install -m644 "powerline/bindings/fish/powerline-setup.fish" "$out/share/fish/vendor_functions.d/powerline-setup.fish"
Comment on lines +41 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install -dm755 "$out/share/fish/vendor_functions.d"
install -m644 "powerline/bindings/fish/powerline-setup.fish" "$out/share/fish/vendor_functions.d/powerline-setup.fish"
installShellCompletion powerline/bindings/fish/powerline-setup.fish

... else where

nativeBuildInputs = [ installShellFiles ];

Copy link
Contributor Author

@justin-gerhardt justin-gerhardt May 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had seen that, however installShellCompletion can't be used in this case. The integration has to be installed to vendor_functions.d and not vendor_completions.d, as Powerline provides a function not a completion. I don't see any helper functions for installing functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see. okay then


'';

meta = {
Expand Down