Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.toggl-cli: relax click version dependency #86921

Merged
merged 1 commit into from May 5, 2020

Conversation

@stigtsp
Copy link
Member

stigtsp commented May 5, 2020

fixes build problem by substituting click==7.0 with click>=7.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
fixes build problem by substituting click==7.0 with click>=7.0.
@stigtsp stigtsp requested review from FRidh and jonringer as code owners May 5, 2020
@ofborg ofborg bot added the 6.topic: python label May 5, 2020
@ofborg ofborg bot requested a review from mmahut May 5, 2020
@Mic92
Copy link
Contributor

Mic92 commented May 5, 2020

Also opened a ticket for python3.8: AuHau/toggl-cli#138

@Mic92 Mic92 merged commit 40b89a0 into NixOS:master May 5, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b693794"; rev="b69379415be0b467464ec527b8e5bf160106356f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Mic92
Copy link
Contributor

Mic92 commented May 24, 2020

Upstream said the next release will support python 3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.