sidequest: 0.10.2 -> 0.10.4, fix file picker

[leo60228]

Motivation for this change

SideQuest 0.10.4 is the final MIT licensed version, with later versions being proprietary. As changing a license to an unfree one is a breaking change, and I'm unsure of nixpkgs's policy on this, I chose to use this version.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[leo60228]

The Nixpkgs manual says this:

License can change with version updates, so it should be checked to match the upstream license.

However, I'm not sure if this counts for changes from free to unfree licenses, or just for free licenses to other free licenses.

[rvolosatovs]

https://github.com/the-expanse/SideQuest/blob/v0.10.9/LICENSE
v0.10.9 seems to be the latest currently and MIT licensed still?

[leo60228]

That's the 0.10.4 code.

[rvolosatovs]

That's the 0.10.4 code.

I see, sorry for the confusion. Didn't expect it to still be released on Github

I think the correct way of doing this would be introducing another version of the package (one, which would track latest closed-source updates and one, which would just be locked on 0.10.4)

That said I also prefer staying on the open-source version software - perhaps we could file an issue about this, so in case someone wants to use the up-to-date version - they would know what to do?

[Lassulus]

seems like someone updated it in the meantime. Should this be rebased or closed?

[leo60228]

Yes, but I'm opening an issue about the license.