Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5.qtgamepad: init at 5.12.7 #87751

Merged
merged 1 commit into from May 15, 2020
Merged

qt5.qtgamepad: init at 5.12.7 #87751

merged 1 commit into from May 15, 2020

Conversation

@HenkKalkwater
Copy link
Contributor

HenkKalkwater commented May 13, 2020

Motivation for this change

Qt Gamepad was missing as a Qt module. I do not know many projects which depend on it, but one of my personal ones does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    (Since it's a library, there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
    (Is there any to update?)
  • Fits CONTRIBUTING.md.
Things not done
  • Actually trying to build an existing application with this library, since my CMake doesn't behave as it used to on other distros.
  • I believe QtGamepad has the option to link against libsdl, but it's not required. This option is not implemented.
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87751 1

1 package marked as broken and skipped:
- multibootusb
3 packages built:
- luxcorerender
- qt5Full (qt5.full)
- qt5.qtgamepad (qt512.qtgamepad)

@jonringer jonringer merged commit 5ecd99b into NixOS:master May 15, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fb895d4"; rev="fb895d4121b9213e4842a9cc44fe1df89dbede4e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qt5.qtgamepad, qt5.qtgamepad.passthru.tests on aarch64-linux Success
Details
qt5.qtgamepad, qt5.qtgamepad.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.