Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium: Fix .desktop file #87799

Merged
merged 1 commit into from May 14, 2020
Merged

Conversation

@turion
Copy link
Contributor

turion commented May 14, 2020

Motivation for this change

Fix #87768.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@piegamesde as reporter, can you test this PR by using nix-shell -p nixpkgs-review --run "nixpkgs-review 87799"?
@Synthetica9 Can you review and/or merge?

@piegamesde
Copy link

piegamesde commented May 14, 2020

nix-shell -p nixpkgs-review --run "nixpkgs-review 87799" errors out with

usage: /nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review
       [-h] {post-result,approve,merge,pr,rev,wip} ...
/nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review: error: argument subcommand: invalid choice: '87799' (choose from 'post-result', 'approve', 'merge', 'pr', 'rev', 'wip')

But nix-shell -p nixpkgs-review --run "nixpkgs-review 87799" runs just fine, if that's the correct thing I should do (disclaimer: this is my first nixpkgs bug report).

I also tried simply running vscodium from the PR branch and it resolves the issue for me.

@turion
Copy link
Contributor Author

turion commented May 14, 2020

nix-shell -p nixpkgs-review --run "nixpkgs-review 87799" errors out with

usage: /nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review
       [-h] {post-result,approve,merge,pr,rev,wip} ...
/nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review: error: argument subcommand: invalid choice: '87799' (choose from 'post-result', 'approve', 'merge', 'pr', 'rev', 'wip')

Ooops, my bad. Should have been nix-shell -p nixpkgs-review --run "nixpkgs-review pr 87799" (Note the missing pr)

I also tried simply running vscodium from the PR branch and it resolves the issue for me.

Well, that's the best then :)

@nixos-discourse
Copy link

nixos-discourse commented May 14, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/156

@bhipple
Copy link
Contributor

bhipple commented May 14, 2020

Result of nixpkgs-review pr 87799 1

1 package built:
- vscodium
@bhipple bhipple merged commit 91fce0f into NixOS:master May 14, 2020
16 checks passed
16 checks passed
vscodium, vscodium.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91f58ec"; rev="91f58ec9ccdc07165e35902748cb60b40492e3ff"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vscodium, vscodium.passthru.tests on x86_64-linux Success
Details
@turion turion deleted the turion:fix_vscodium_desktop_file_87768 branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.