Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jugglinglab: init at 1.2 #87875

Merged
merged 2 commits into from May 16, 2020
Merged

jugglinglab: init at 1.2 #87875

merged 2 commits into from May 16, 2020

Conversation

@wnklmnn
Copy link
Contributor

wnklmnn commented May 15, 2020

Motivation for this change

Adds jugglinglab. A program to visualize different juggling patterns.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wnklmnn wnklmnn force-pushed the wnklmnn:jugglinglab branch from f57cc6d to 8f475b0 May 15, 2020
Copy link
Contributor

edibopp left a comment

Hello, there :)

Thanks for taking the time to contribute a package to nixpkgs. I reviewed your PR and found a few small issues, which I added as comments. Here's a summary following the review guide for new packages.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines (but not up-to-date)
  • package build on x86_64, NixOS
  • executables tested on x86_64, NixOS
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set MISSING
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function (no, fetchgit used for GitHub repo)
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch (no patches)
Possible improvements

see code comments

stdenv.mkDerivation rec {
major= "1";
minor = "2";
version = "${major}.${minor}";

This comment has been minimized.

Copy link
@edibopp

edibopp May 15, 2020

Contributor

Looks like the most recent version is 1.2.1 and the program gives me a pop-up saying that there is an update. So I would suggest an update ;)

Minor nit-pick: since you are not really using major/minor version info for anything other than the version, I would collapse this down to version = "1.2.1", as it makes the code easier to follow.

@@ -7204,6 +7204,8 @@ in

umlet = callPackage ../tools/misc/umlet { };

jugglinglab = callPackage ../tools/misc/jugglinglab { };

This comment has been minimized.

Copy link
@edibopp

edibopp May 15, 2020

Contributor

For consistency, please sort this alphabetically.

minor = "2";
version = "${major}.${minor}";
name = "jugglinglab";
src = fetchgit {

This comment has been minimized.

Copy link
@edibopp

edibopp May 15, 2020

Contributor

We prefer fetchFromGitHub over fetchgit for GitHub repositories.

meta = with stdenv.lib; {
description = "A program to visualize different juggling pattens";
license = licenses.gpl2;
maintainers = with maintainers; [ wnklmnn ];

This comment was marked as resolved.

Copy link
@edibopp

edibopp May 15, 2020

Contributor

Please add meta.platforms for binary caching, have a look at nixpkgs manual sec. 7.1. Standard meta-attributes for reference.

Copy link
Contributor

edibopp left a comment

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on NixOS x86_64
  • executables tested on NixOS x86_64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch (none)
Possible improvements

none

Comments

👍 looks good to me!

@cdepillabout
Copy link
Member

cdepillabout commented May 16, 2020

LGTM

@wnklmnn Thanks for sending this PR, and we look forward to more contributions from you in the future!

@aepsil0n Thanks for doing a quick review of this.

@cdepillabout cdepillabout merged commit 8226394 into NixOS:master May 16, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b94e8cc"; rev="b94e8cc448e1c834b42bf0704748981833ef1a72"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jugglinglab, jugglinglab.passthru.tests on aarch64-linux Success
Details
jugglinglab, jugglinglab.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.