Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zenith: re-enable aarch64 #88616

Closed
wants to merge 1 commit into from
Closed

zenith: re-enable aarch64 #88616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkgs/tools/system/zenith/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@ rustPlatform.buildRustPackage rec {

buildInputs = stdenv.lib.optionals stdenv.isDarwin [ IOKit ];

preBuild = ''
export CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=gcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using preBuild, I believe you can simply write

CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER = "gcc";

and the call to mkDerivation underlying buildRustPackage will interpret it as setting an environment variable for the build process.

'';

meta = with stdenv.lib; {
description = "Sort of like top or htop but with zoom-able charts, network, and disk usage";
homepage = "https://github.com/bvaisvil/zenith";
license = licenses.mit;
maintainers = with maintainers; [ bbigras ];
# doesn't build on aarch64 https://github.com/bvaisvil/zenith/issues/19
platforms = platforms.x86;
platforms = platforms.all;
};
}