Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qv2ray: Init at 2.5.0 #89322

Open
wants to merge 2 commits into
base: master
from
Open

qv2ray: Init at 2.5.0 #89322

wants to merge 2 commits into from

Conversation

@poscat0x04
Copy link
Contributor

poscat0x04 commented Jun 1, 2020

Motivation for this change

qv2ray is a GUI frontend to the network proxying tool v2ray.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@poscat0x04
Copy link
Contributor Author

poscat0x04 commented Jun 1, 2020

Thank you for your generous help! I'm terribly sorry that I forgot to read the nixpkgs manual before opening this PR and I'll try to be less careless next time.


meta = with stdenv.lib; {
description = "An GUI frontend to v2ray";
homepage = https://qv2ray.github.io/en/;

This comment has been minimized.

Copy link
@symphorien

symphorien Jun 1, 2020

Contributor
Suggested change
homepage = https://qv2ray.github.io/en/;
homepage = "https://qv2ray.github.io/en/";

due to https://github.com/NixOS/rfcs/pull/45/files

This comment has been minimized.

Copy link
@jonringer

jonringer Jul 3, 2020

Contributor

this is still relevant

Copy link
Contributor

symphorien left a comment

compiles fine with nix-review and a window shows up when launched.

poscat0x04 added 2 commits Jun 2, 2020
@poscat0x04 poscat0x04 force-pushed the poscat0x04:add-qv2ray branch from 154f606 to e12040e Jun 2, 2020
@nixos-discourse
Copy link

nixos-discourse commented Jul 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/213

Copy link
Contributor

jonringer left a comment

use qt5's mkDerivation, it will automatically wrap the programs for you


meta = with stdenv.lib; {
description = "An GUI frontend to v2ray";
homepage = https://qv2ray.github.io/en/;

This comment has been minimized.

Copy link
@jonringer

jonringer Jul 3, 2020

Contributor

this is still relevant

maintainers = with maintainers; [
poscat
];
Comment on lines +64 to +66

This comment has been minimized.

Copy link
@jonringer

jonringer Jul 3, 2020

Contributor
Suggested change
maintainers = with maintainers; [
poscat
];
maintainers = with maintainers; [ poscat ];
pkgconfig
qmake
qttools
wrapQtAppsHook

This comment has been minimized.

Copy link
@jonringer

jonringer Jul 3, 2020

Contributor
Suggested change
wrapQtAppsHook
, zlib
}:

stdenv.mkDerivation rec {

This comment has been minimized.

Copy link
@jonringer

jonringer Jul 3, 2020

Contributor
Suggested change
stdenv.mkDerivation rec {
mkDerivation rec {
@@ -0,0 +1,69 @@
{ stdenv

This comment has been minimized.

Copy link
@jonringer

jonringer Jul 3, 2020

Contributor
Suggested change
{ stdenv
{ stdenv
, mkDerivation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.