Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qv2ray: Init at 2.6.3 #89322

Merged
merged 2 commits into from Nov 29, 2020
Merged

qv2ray: Init at 2.6.3 #89322

merged 2 commits into from Nov 29, 2020

Conversation

@poscat0x04
Copy link
Contributor

@poscat0x04 poscat0x04 commented Jun 1, 2020

Motivation for this change

qv2ray is a GUI frontend to the network proxying tool v2ray.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@poscat0x04
Copy link
Contributor Author

@poscat0x04 poscat0x04 commented Jun 1, 2020

Thank you for your generous help! I'm terribly sorry that I forgot to read the nixpkgs manual before opening this PR and I'll try to be less careless next time.

Copy link
Member

@symphorien symphorien left a comment

compiles fine with nix-review and a window shows up when launched.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jul 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/213

Copy link
Contributor

@jonringer jonringer left a comment

use qt5's mkDerivation, it will automatically wrap the programs for you

pkgs/applications/networking/qv2ray/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/qv2ray/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/qv2ray/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/qv2ray/default.nix Outdated Show resolved Hide resolved
@poscat0x04 poscat0x04 force-pushed the add-qv2ray branch 2 times, most recently from 7a47456 to f9b29ab Nov 23, 2020
@poscat0x04 poscat0x04 changed the title qv2ray: Init at 2.5.0 qv2ray: Init at 2.6.3 Nov 23, 2020
@poscat0x04
Copy link
Contributor Author

@poscat0x04 poscat0x04 commented Nov 23, 2020

ping @jonringer

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 28, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/390

marsam
marsam approved these changes Nov 29, 2020
@marsam marsam merged commit 84a942c into NixOS:master Nov 29, 2020
19 checks passed
@poscat0x04 poscat0x04 deleted the add-qv2ray branch Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants