New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fltk1{3,4}: refactor #89929
fltk1{3,4}: refactor #89929
Conversation
Essentially paused while upstream is working on some structural improvements to their CMake config that'll obsolete the custom patches here. Still very much interested in getting this completed, still no clue about the TeX-related problems. |
@OPNA2608 friendly ping |
Still interested in this. I believe still waiting for upstream - see fltk/fltk#97, mostly regarding backports to 1.3. Prolly still no clue about the TeX docs, but I can try to fiddle more with it some time. |
description = "A C++ cross-platform lightweight GUI library"; | ||
homepage = "https://www.fltk.org"; | ||
platforms = with platforms; linux ++ darwin; | ||
license = licenses.lgpl2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgpl2Only or lpgpl2Plus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified it for now, not sure if it makes sense to give them their own license instead? See https://www.fltk.org/COPYING.php.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment to see their site for exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already did that, the view here is just outdated.
# LGPL2 with static linking exception
# https://www.fltk.org/COPYING.php
license = licenses.lgpl2Only;
932b20c
to
ea59abb
Compare
It seems that upstream fixed this.
We can do with just
Any suggestions for how to deal with that?
I changed the
Still need to sort out Darwin stuff by testing it locally, haven't had the time yet.
I think I checked and it worked again, but generating both HTML & PDF documentations at the same time was broken now so I only set up the HTML one. I'll see if I can fix that & submit a patch upstream. I added a |
57b5d70
to
c0ab9d5
Compare
Targeting staging due to the amount of rebuilds. |
You can target master with less than 500 rebuilds. |
Mmh, okay.
I'll check what's going wrong there.
Regarding cairo on Darwin, I'll check if it works on 1.4 and consider writing upstream about it if they have a clue. I think the HTML docs were broken too? Result of 8 packages marked as broken and skipped:
1 package failed to build:
133 packages built:
|
FLTK doesn't dictate linking against libXi, so virtualgl should declare that its own buildInputs.
Alternative would be to patch in the flags required for cairo, but this is easier and more in-tune with the project.
Fingers crossed that I didn't miss anything? 🤞 |
Result of 10 packages marked as broken and skipped:
2 packages failed to build:
7 packages built:
Failures are either also present on Hydra (librsb, octaveFull) or due to at-first-glance unrelated issues? Result of 13 packages marked as broken and skipped:
1 package failed to build:
55 packages built:
Result of 8 packages marked as broken and skipped:
135 packages built:
|
Needs more comprehensive testing of packages depending on FLTK & which
propagatedBuildInputs
are actually needed. Feedback on whether to keep this attribute-per-option approach or switch to some dynamic attribute name -> CMake option conversion would be great.Motivation for this change
Things done
boost
added all cmake options via attributes that versions can override as needednot all, only some useful onesnixpkgs-fmt
CMake generates shared libraries with an extra suffix by default, patches -0001-as based on upstream PR fltk/fltk#21 fix this.
CMake switch breaks fltk-config generation, partly addressed in -0002-
patches. Hard references to CC and CXX used at FLTK compile time remain,
needs more patching post-build.
Some of the propagatedBuildInputs might not be required, I tested some FLTK
applications with only xorgproto and encountered no problems.
PDF documentation errors, no clue how to fix (uses
texlive
and some more stuff)See comment for in-between assessments.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)