Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnustep.libobjc: 1.9 -> 2.0 #90017

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented Jun 10, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libobjc2/versions.

meta.description for gnustep.libobjc is: "Objective-C runtime for use with GNUstep"

meta.homepage for gnustep.libobjc is: "http://gnustep.org/"

meta.changelog for gnustep.libobjc is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
48 total rebuild path(s)

15 package rebuild(s)

15 x86_64-linux rebuild(s)
15 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
15 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
bookworm
gnustep.back
gnustep.base
gnustep.gorm
gnustep.gui
gnustep.gworkspace
gnustep.libobjc
gnustep.make
gnustep.projectcenter
gnustep.system_preferences
hopper
openvpn-auth-ldap
sogo
sope
unar
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/f4x68q8p0cjwggl9j4qzfvq7j0znf6q1-libobjc2-2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gnustep.libobjc https://github.com/r-ryantm/nixpkgs/archive/ce76af4412433c0c6a11398290893cae91f5c25e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/f4x68q8p0cjwggl9j4qzfvq7j0znf6q1-libobjc2-2.0
ls -la /nix/store/f4x68q8p0cjwggl9j4qzfvq7j0znf6q1-libobjc2-2.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package marked as broken and skipped:
- unarj
15 packages built:
- bookworm
- gnustep-make (gnustep.make)
- gnustep.back
- gnustep.base
- gnustep.gorm
- gnustep.gui
- gnustep.gworkspace
- gnustep.libobjc
- gnustep.projectcenter
- gnustep.system_preferences
- hopper
- openvpn-auth-ldap
- sogo
- sope
- unar

Maintainer pings

cc @ashalkhakov @matthewbauer for testing.

@ofborg ofborg bot requested review from ashalkhakov and matthewbauer Jun 10, 2020
@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/libobjc2 branch Jun 11, 2020
@ryantm ryantm restored the r-ryantm:auto-update/libobjc2 branch Jun 11, 2020
@ryantm ryantm reopened this Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/libobjc2 branch Jun 14, 2020
@ryantm ryantm restored the r-ryantm:auto-update/libobjc2 branch Jun 14, 2020
@ryantm ryantm reopened this Jun 14, 2020
@ajs124
Copy link
Member

ajs124 commented Jun 17, 2020

We already had this, see #62464. I reverted it in #79175, because it broke SOGo and nothing else seems to really profit from it. Ideally SOGo would just be made to work, but if you look at the changelog, this release introduces a new major ABI (after several decades) and does lots of low-level things. I'm not sure any major distribution ships with this release yet, so the SOGo <-> libobjc2 2.0 incompatibility might be either upstream in SOGo or libobjc2 and it's just that nobody noticed yet. That or we could be doing something wrong. Considering how much gnustep doesn't want to work the way nix works, this isn't that unlikely.

Anyways: long story short, I'm against merging this, for now.

Copy link
Member

ryantm left a comment

Don't merge until above issues are addressed.

@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/libobjc2 branch Jul 1, 2020
@ryantm ryantm restored the r-ryantm:auto-update/libobjc2 branch Jul 1, 2020
@ryantm ryantm reopened this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.